<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17898">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove redundant functions<br><br>Change-Id: I2dfb5b662b8a4f351e4a629040b405c182e58e8d<br>---<br>M pySim/cards.py<br>M pySim/utils.py<br>2 files changed, 0 insertions(+), 30 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index c0462fb..d2f1057 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -188,14 +188,6 @@</span><br><span>          else:</span><br><span>                        return (None, sw)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   # Read SIM Service table</span><br><span style="color: hsl(0, 100%, 40%);">-        def read_sst(self):</span><br><span style="color: hsl(0, 100%, 40%);">-             (res, sw) = self._scc.read_binary(EF['SST'])</span><br><span style="color: hsl(0, 100%, 40%);">-            if sw == '9000':</span><br><span style="color: hsl(0, 100%, 40%);">-                        return ((res, parse_st(res)), sw)</span><br><span style="color: hsl(0, 100%, 40%);">-               else:</span><br><span style="color: hsl(0, 100%, 40%);">-                   return (None, sw)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    # Read the (full) AID for either ISIM or USIM or ISIM application</span><br><span>    def read_aid(self, isim = False):</span><br><span> </span><br><span>diff --git a/pySim/utils.py b/pySim/utils.py</span><br><span>index be670e9..56f9706 100644</span><br><span>--- a/pySim/utils.py</span><br><span>+++ b/pySim/utils.py</span><br><span>@@ -326,28 +326,6 @@</span><br><span> </span><br><span>        return ('%02x' % bcd_len) + ('%02x' % npi_ton) + bcd</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-def parse_st(st):</span><br><span style="color: hsl(0, 100%, 40%);">-       """</span><br><span style="color: hsl(0, 100%, 40%);">-      Parses the EF S/U/IST and returns available/supported services</span><br><span style="color: hsl(0, 100%, 40%);">-  """</span><br><span style="color: hsl(0, 100%, 40%);">-      st_bytes = [st[i:i+2] for i in range(0, len(st), 2) ]</span><br><span style="color: hsl(0, 100%, 40%);">-   avail_srvc = []</span><br><span style="color: hsl(0, 100%, 40%);">- # Get each byte and check for available services</span><br><span style="color: hsl(0, 100%, 40%);">-        for i in range(0, len(st_bytes)):</span><br><span style="color: hsl(0, 100%, 40%);">-               # Byte i contains info about Services num (8i+1) to num (8i+8)</span><br><span style="color: hsl(0, 100%, 40%);">-          byte = int(st_bytes[i], 16)</span><br><span style="color: hsl(0, 100%, 40%);">-             # Services in each byte are in order MSB to LSB</span><br><span style="color: hsl(0, 100%, 40%);">-         # MSB - Service (8i+8)</span><br><span style="color: hsl(0, 100%, 40%);">-          # LSB - Service (8i+1)</span><br><span style="color: hsl(0, 100%, 40%);">-          for j in range(1, 9):</span><br><span style="color: hsl(0, 100%, 40%);">-                   if byte&0x01 == 0x01:</span><br><span style="color: hsl(0, 100%, 40%);">-                               # Byte X contains info about Services num (8X-7) to num (8X)</span><br><span style="color: hsl(0, 100%, 40%);">-                            # bit = 1: service available</span><br><span style="color: hsl(0, 100%, 40%);">-                            # bit = 0: service not available</span><br><span style="color: hsl(0, 100%, 40%);">-                                avail_srvc.append((8*i) + j)</span><br><span style="color: hsl(0, 100%, 40%);">-                    byte = byte >> 1</span><br><span style="color: hsl(0, 100%, 40%);">-  return avail_srvc</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> def dec_st(st, table="sim"):</span><br><span>  """</span><br><span>   Parses the EF S/U/IST and prints the list of available services in EF S/U/IST</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17898">change 17898</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17898"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2dfb5b662b8a4f351e4a629040b405c182e58e8d </div>
<div style="display:none"> Gerrit-Change-Number: 17898 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>