<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17983">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data block<br><br>Even if we don't accept it, let's submit GSMTAP with correct channel.<br>We don't return error like in code below, because otherwise the generic<br>UNKNOWN gsmtap message will be sent.<br><br>Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9<br>---<br>M src/pdch.cpp<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/17983/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index f46acc8..77be1b5 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -793,14 +793,14 @@</span><br><span>   * control blocks (see 44.060, section 10.3, 1st par.)</span><br><span>        */</span><br><span>  if (mcs_is_edge(cs)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_EGPRS, true, trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,</span><br><span style="color: hsl(120, 100%, 40%);">+                               data, data_len);</span><br><span>          if (!bts()->bts_data()->egprs_enabled) {</span><br><span>                       LOGP(DRLCMACUL, LOGL_ERROR,</span><br><span>                          "Got %s RLC block but EGPRS is not enabled\n",</span><br><span>                             mcs_name(cs));</span><br><span style="color: hsl(0, 100%, 40%);">-                  return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+                       return 0;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_EGPRS, true, trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 data, data_len);</span><br><span>  } else {</span><br><span>             bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_GPRS, true, trx_no(), ts_no, GSMTAP_CHANNEL_PDTCH, fn,</span><br><span>                               data, data_len);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17983">change 17983</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17983"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9 </div>
<div style="display:none"> Gerrit-Change-Number: 17983 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>