<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17971">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU: fix f_pcuif_tx_data_cnf(): do not include paging group<br><br>As it turns out, DATA.cnf shall not contain paging group.<br><br>Change-Id: I7e0d1bb03fd42fc742f1f3d13a48e9781975dc17<br>---<br>M pcu/PCU_Tests_RAW.ttcn<br>1 file changed, 11 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn</span><br><span>index 09ff4e3..b79b365 100644</span><br><span>--- a/pcu/PCU_Tests_RAW.ttcn</span><br><span>+++ b/pcu/PCU_Tests_RAW.ttcn</span><br><span>@@ -249,12 +249,21 @@</span><br><span>  * NOTE: it's the responsibility of caller to make sure that pcu_msg contains u.data_req. */</span><br><span> private function f_pcuif_tx_data_cnf(in PCUIF_Message pcu_msg)</span><br><span> runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-      BTS.send(PCUIF_Message:{</span><br><span style="color: hsl(120, 100%, 40%);">+      var PCUIF_Message pcu_msg_cnf := {</span><br><span>           msg_type := PCU_IF_MSG_DATA_CNF,</span><br><span>             bts_nr := pcu_msg.bts_nr,</span><br><span>            spare := pcu_msg.spare,</span><br><span>              u := { data_cnf := pcu_msg.u.data_req }</span><br><span style="color: hsl(0, 100%, 40%);">- });</span><br><span style="color: hsl(120, 100%, 40%);">+   };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* PCU wants DATA.cnf containing basically everything that was in DATA.req,</span><br><span style="color: hsl(120, 100%, 40%);">+    * but PCU_IF_SAPI_PCH is a special case - paging group shall be excluded. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pcu_msg.u.data_req.sapi == PCU_IF_SAPI_PCH) {</span><br><span style="color: hsl(120, 100%, 40%);">+             pcu_msg_cnf.u.data_cnf.data := substr(pcu_msg.u.data_req.data, 3,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                   pcu_msg.u.data_req.len - 3);</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   BTS.send(pcu_msg_cnf);</span><br><span> }</span><br><span> </span><br><span> private function f_pcuif_rx_imm_ass(out GsmRrMessage rr_imm_ass,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17971">change 17971</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17971"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e0d1bb03fd42fc742f1f3d13a48e9781975dc17 </div>
<div style="display:none"> Gerrit-Change-Number: 17971 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>