<p><a href="https://gerrit.osmocom.org/c/pysim/+/17883">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py">File pySim/utils.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@365">Patch Set #1, Line 365:</a> <code style="font-family:monospace,monospace">          if o</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">shouldn't we use some generic TLV parser utility code rather than hand-coding this here?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">this is addressed in future commits which I will be submitting - https://github.com/herlesupreeth/pysim/commit/62e9f32474c6ee5b72d39edc30a476932f42d4a6</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@375">Patch Set #1, Line 375:</a> <code style="font-family:monospace,monospace">               #</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">maybe implent that TODO first?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I have addressed in future commits the IPv4 part. Regarding the IPv6, I still searching for a proper validation of IPv6 provided by the user. </p><p style="white-space: pre-wrap; word-wrap: break-word;">https://github.com/herlesupreeth/pysim/commit/611e4d03d751ee79f24eefa267db731152c1c09b</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17883">change 17883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I96fb129d178cfd7ec037989526da77899ae8d344 </div>
<div style="display:none"> Gerrit-Change-Number: 17883 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 26 Apr 2020 04:43:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>