<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17932">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">firmware/rfch.[ch]: Document functions + constify input arguments<br><br>Change-Id: I16d5190b3cdc997c5609b52d41203f10264b017c<br>---<br>M src/target/firmware/include/layer1/rfch.h<br>M src/target/firmware/layer1/rfch.c<br>2 files changed, 16 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/firmware/include/layer1/rfch.h b/src/target/firmware/include/layer1/rfch.h</span><br><span>index 344523c..0c4f9a0 100644</span><br><span>--- a/src/target/firmware/include/layer1/rfch.h</span><br><span>+++ b/src/target/firmware/include/layer1/rfch.h</span><br><span>@@ -3,7 +3,7 @@</span><br><span> </span><br><span> struct gsm_time;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void rfch_get_params(struct gsm_time *t,</span><br><span style="color: hsl(120, 100%, 40%);">+void rfch_get_params(const struct gsm_time *t,</span><br><span>                      uint16_t *arfcn_p, uint8_t *tsc_p, uint8_t *tn_p);</span><br><span> </span><br><span> #endif /* _L1_RFCH_H */</span><br><span>diff --git a/src/target/firmware/layer1/rfch.c b/src/target/firmware/layer1/rfch.c</span><br><span>index d0818d0..3c4e676 100644</span><br><span>--- a/src/target/firmware/layer1/rfch.c</span><br><span>+++ b/src/target/firmware/layer1/rfch.c</span><br><span>@@ -82,9 +82,16 @@</span><br><span>  return x;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int16_t rfch_hop_seq_gen(struct gsm_time *t,</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Hopping sequence generator.</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] t GSM time (frame number)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] hsn Hopping Sequence Number</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] maio Mobile Allocation Index OFfset</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] n number of entries in mobile allocation (arfcn table)</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param[in] arfcn_tbl Array of ARFCN representing the mobile allocation</span><br><span style="color: hsl(120, 100%, 40%);">+ * \returns ARFCN to use for given input parameters at time 't' or MAI if arfcn_tbl == NULL */</span><br><span style="color: hsl(120, 100%, 40%);">+static int16_t rfch_hop_seq_gen(const struct gsm_time *t,</span><br><span>                                 uint8_t hsn, uint8_t maio,</span><br><span style="color: hsl(0, 100%, 40%);">-                                uint8_t n, uint16_t *arfcn_tbl)</span><br><span style="color: hsl(120, 100%, 40%);">+                                uint8_t n, const uint16_t *arfcn_tbl)</span><br><span> {</span><br><span>   int mai;</span><br><span> </span><br><span>@@ -114,8 +121,12 @@</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* RF Channel parameters */</span><br><span style="color: hsl(0, 100%, 40%);">-void rfch_get_params(struct gsm_time *t,</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Get RF Channel parameters at a given GSM time (frame number)</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[in] t GSM time for which to obtain parameters</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[out] arfcn_p ARFCN to use at time t</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \oaram[out] tsc_p Training sequence to use at time t</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[out] tn_p Timeslot Number to use at time t */</span><br><span style="color: hsl(120, 100%, 40%);">+void rfch_get_params(const struct gsm_time *t,</span><br><span>                      uint16_t *arfcn_p, uint8_t *tsc_p, uint8_t *tn_p)</span><br><span> {</span><br><span>   if (l1s.dedicated.type == GSM_DCHAN_NONE) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17932">change 17932</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/17932"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16d5190b3cdc997c5609b52d41203f10264b017c </div>
<div style="display:none"> Gerrit-Change-Number: 17932 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>