<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17855">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c">File src/osmo-bts-litecell15/l1_if.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1722">Patch Set #4, Line 1722:</a> <code style="font-family:monospace,monospace">     fl1h->hw_alive.dsp_alive_timer.cb = dsp_alive_timer_cb;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">As a callback which the return value nobody takes cares, fixing this has no semantic effect. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't the return of -EIO key to the whole point of the thing?</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd be wary of unifying the oc2g code if this is just introducing logic errors. Where did the oc2g code come from?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/17855">change 17855</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/17855"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib16e7d423fc7030573acd86fbd356ae96697ed5d </div>
<div style="display:none"> Gerrit-Change-Number: 17855 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: rafael2k <rafael@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: rafael2k <rafael@rhizomatica.org> </div>
<div style="display:none"> Gerrit-CC: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 20 Apr 2020 16:08:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Comment-In-Reply-To: rafael2k <rafael@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>