<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/17871">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SMS-over-GSUP: move net->sms_over_gsup check to gsm411_gsup_rx()<br><br>Change-Id: I89988b7148b164af304ecae1f53b74f322fdc7bd<br>---<br>M src/libmsc/gsm_04_11_gsup.c<br>1 file changed, 8 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/17871/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c</span><br><span>index dfc90cc..1751655 100644</span><br><span>--- a/src/libmsc/gsm_04_11_gsup.c</span><br><span>+++ b/src/libmsc/gsm_04_11_gsup.c</span><br><span>@@ -149,14 +149,6 @@</span><br><span>                 OSMO_ASSERT(0);</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* Make sure that 'SMS over GSUP' is expected */</span><br><span style="color: hsl(0, 100%, 40%);">-        if (!net->sms_over_gsup) {</span><br><span style="color: hsl(0, 100%, 40%);">-           /* TODO: notify sender about that? */</span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO SMS over GSUP "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "(sms-over-gsup is not enabled), ignoring message...\n");</span><br><span style="color: hsl(0, 100%, 40%);">-             return -EIO;</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* Verify GSUP message */</span><br><span>    if (!gsup_msg->sm_rp_mr)</span><br><span>          goto msg_error;</span><br><span>@@ -241,14 +233,6 @@</span><br><span> </span><br><span>   LOGP(DLSMS, LOGL_DEBUG, "RX MT-forwardSM-Req\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Make sure that 'SMS over GSUP' is expected */</span><br><span style="color: hsl(0, 100%, 40%);">-        if (!net->sms_over_gsup) {</span><br><span style="color: hsl(0, 100%, 40%);">-           LOGP(DLSMS, LOGL_NOTICE, "Unexpected MT SMS over GSUP "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "(sms-over-gsup is not enabled), ignoring message...\n");</span><br><span style="color: hsl(0, 100%, 40%);">-             /* TODO: notify sender about that? */</span><br><span style="color: hsl(0, 100%, 40%);">-           return -EIO;</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /**</span><br><span>   * Verify GSUP message</span><br><span>        *</span><br><span>@@ -296,6 +280,14 @@</span><br><span>    struct vlr_subscr *vsub;</span><br><span>     int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   /* Make sure that 'SMS over GSUP' is expected */</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!net->sms_over_gsup) {</span><br><span style="color: hsl(120, 100%, 40%);">+         /* TODO: notify sender about that? */</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO/MT SMS over GSUP "</span><br><span style="color: hsl(120, 100%, 40%);">+                  "(sms-over-gsup is not enabled), ignoring message...\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           return -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  vsub = vlr_subscr_find_by_imsi(net->vlr, gsup_msg->imsi, __func__);</span><br><span>    if (!vsub) {</span><br><span>                 LOGP(DLSMS, LOGL_ERROR, "Rx %s for unknown subscriber, rejecting\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/17871">change 17871</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/17871"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I89988b7148b164af304ecae1f53b74f322fdc7bd </div>
<div style="display:none"> Gerrit-Change-Number: 17871 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>