<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-uecups/+/17885">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">work around bogus compiler warnings<br><br>Change-Id: I9170e4de857c1f3e003a480b12dd16fe796ec763<br>---<br>M daemon/daemon_vty.c<br>M daemon/gtp_tunnel.c<br>M daemon/main.c<br>M daemon/tun_device.c<br>4 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/daemon/daemon_vty.c b/daemon/daemon_vty.c</span><br><span>index efd9c0f..c84c727 100644</span><br><span>--- a/daemon/daemon_vty.c</span><br><span>+++ b/daemon/daemon_vty.c</span><br><span>@@ -127,7 +127,7 @@</span><br><span>     "Local IP address\n" "Local UDP Port\n")</span><br><span> {</span><br><span>    struct gtp_endpoint *ep;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct addrinfo *ai;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct addrinfo *ai = NULL;</span><br><span>  const char *ipstr;</span><br><span>   uint16_t port = GTP1U_PORT;</span><br><span> </span><br><span>diff --git a/daemon/gtp_tunnel.c b/daemon/gtp_tunnel.c</span><br><span>index 0d049c7..f9075f7 100644</span><br><span>--- a/daemon/gtp_tunnel.c</span><br><span>+++ b/daemon/gtp_tunnel.c</span><br><span>@@ -83,6 +83,7 @@</span><br><span>         return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#if 0</span><br><span> /* find tunnel by R(x_teid), T(x_teid) + A(ddr) */</span><br><span> static struct gtp_tunnel *</span><br><span> _gtp_tunnel_find_rta(struct gtp_daemon *d, uint32_t rx_teid, uint32_t tx_teid,</span><br><span>@@ -96,6 +97,7 @@</span><br><span>       }</span><br><span>    return NULL;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> </span><br><span> /* find tunnel by R(x_teid) + optionally local endpoint */</span><br><span> struct gtp_tunnel *</span><br><span>diff --git a/daemon/main.c b/daemon/main.c</span><br><span>index 863b8b4..a408df4 100644</span><br><span>--- a/daemon/main.c</span><br><span>+++ b/daemon/main.c</span><br><span>@@ -378,7 +378,7 @@</span><br><span>    const char *cmd, *user;</span><br><span>      char **addl_env = NULL;</span><br><span>      sigset_t oldmask;</span><br><span style="color: hsl(0, 100%, 40%);">-       int nsfd, rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ int nsfd = -1, rc;</span><br><span> </span><br><span>       juser = json_object_get(sprog, "run_as_user");</span><br><span>     jcmd = json_object_get(sprog, "command");</span><br><span>diff --git a/daemon/tun_device.c b/daemon/tun_device.c</span><br><span>index 738d492..b1bd7fc 100644</span><br><span>--- a/daemon/tun_device.c</span><br><span>+++ b/daemon/tun_device.c</span><br><span>@@ -205,7 +205,7 @@</span><br><span>   if (name) {</span><br><span>          /* if a TUN interface name was specified, put it in the structure; otherwise,</span><br><span>                   the kernel will try to allocate the "next" device of the specified type */</span><br><span style="color: hsl(0, 100%, 40%);">-         strncpy(ifr.ifr_name, name, IFNAMSIZ);</span><br><span style="color: hsl(120, 100%, 40%);">+                osmo_strlcpy(ifr.ifr_name, name, IFNAMSIZ);</span><br><span>  }</span><br><span> </span><br><span>        /* try to create the device */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-uecups/+/17885">change 17885</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-uecups/+/17885"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-uecups </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9170e4de857c1f3e003a480b12dd16fe796ec763 </div>
<div style="display:none"> Gerrit-Change-Number: 17885 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>