<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/17874">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SMS-over-GSUP: notify sender about malformed GSUP messages<br><br>Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889<br>---<br>M src/libmsc/gsm_04_11_gsup.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/74/17874/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c</span><br><span>index cf9d11d..7c9b6fb 100644</span><br><span>--- a/src/libmsc/gsm_04_11_gsup.c</span><br><span>+++ b/src/libmsc/gsm_04_11_gsup.c</span><br><span>@@ -178,9 +178,8 @@</span><br><span>    return 0;</span><br><span> </span><br><span> msg_error:</span><br><span style="color: hsl(0, 100%, 40%);">-     /* TODO: notify sender about that? */</span><br><span style="color: hsl(0, 100%, 40%);">-   LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-              msg_name, msg_is_err ? "Err" : "Res");</span><br><span style="color: hsl(120, 100%, 40%);">+    LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", msg_name, msg_is_err ? "Err" : "Res");</span><br><span style="color: hsl(120, 100%, 40%);">+ gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO);</span><br><span>      return -EINVAL;</span><br><span> }</span><br><span> </span><br><span>@@ -269,8 +268,8 @@</span><br><span>       return 0;</span><br><span> </span><br><span> msg_error:</span><br><span style="color: hsl(0, 100%, 40%);">-     /* TODO: notify sender about that? */</span><br><span>        LOGP(DLSMS, LOGL_NOTICE, "RX malformed MT-forwardSM-Req\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO);</span><br><span>      return -EINVAL;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/17874">change 17874</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/17874"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889 </div>
<div style="display:none"> Gerrit-Change-Number: 17874 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>