<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17849">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">powersupply: Import sublcass module only if used<br><br>This way we avoid unconditionally importing all subclass dependencies,<br>and make them optional based on whether the setup has devices of that<br>type or not.<br><br>Change-Id: I0d2f8b26364b45f0d837cc51078784d1d0fa7ea1<br>---<br>M src/osmo_gsm_tester/obj/powersupply.py<br>1 file changed, 8 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/49/17849/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/obj/powersupply.py b/src/osmo_gsm_tester/obj/powersupply.py</span><br><span>index 90e84ef..d0d315c 100644</span><br><span>--- a/src/osmo_gsm_tester/obj/powersupply.py</span><br><span>+++ b/src/osmo_gsm_tester/obj/powersupply.py</span><br><span>@@ -50,23 +50,17 @@</span><br><span>         MainLoop.sleep(self, sleep)</span><br><span>         self.power_set(True)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-from . import powersupply_sispm, powersupply_intellinet</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-KNOWN_PWSUPPLY_TYPES = {</span><br><span style="color: hsl(0, 100%, 40%);">-        'sispm' : powersupply_sispm.PowerSupplySispm,</span><br><span style="color: hsl(0, 100%, 40%);">-        'intellinet' : powersupply_intellinet.PowerSupplyIntellinet,</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-def register_type(name, clazz):</span><br><span style="color: hsl(0, 100%, 40%);">-    """Register a new PoerSupply child class at runtime."""</span><br><span style="color: hsl(0, 100%, 40%);">-    KNOWN_PWSUPPLY_TYPES[name] = clazz</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> def get_instance_by_type(pwsupply_type, pwsupply_opt):</span><br><span>     """Allocate a PowerSupply child class based on type. Opts are passed to the newly created object."""</span><br><span style="color: hsl(0, 100%, 40%);">-    obj = KNOWN_PWSUPPLY_TYPES.get(pwsupply_type, None)</span><br><span style="color: hsl(0, 100%, 40%);">-    if not obj:</span><br><span style="color: hsl(120, 100%, 40%);">+    if pwsupply_type == 'sispm':</span><br><span style="color: hsl(120, 100%, 40%);">+        from powersupply_sispm import PowerSupplySispm</span><br><span style="color: hsl(120, 100%, 40%);">+        obj = PowerSupplySispm</span><br><span style="color: hsl(120, 100%, 40%);">+    elif pwsupply_type == 'intellinet':</span><br><span style="color: hsl(120, 100%, 40%);">+        from powersupply_intellinet import PowerSupplyIntellinet</span><br><span style="color: hsl(120, 100%, 40%);">+        obj = PowerSupplyIntellinet</span><br><span style="color: hsl(120, 100%, 40%);">+    else:</span><br><span>         raise log.Error('PowerSupply type not supported:', pwsupply_type)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     return obj(pwsupply_opt)</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17849">change 17849</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17849"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0d2f8b26364b45f0d837cc51078784d1d0fa7ea1 </div>
<div style="display:none"> Gerrit-Change-Number: 17849 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>