<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17759">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/app_common: introduce auxiliary add_log_handler()<br><br>Change-Id: Ied32764cf1c34dc7e0f746f4f085ea20168775cb<br>---<br>M src/target/trx_toolkit/app_common.py<br>1 file changed, 14 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py</span><br><span>index f2a47c5..8ee5054 100644</span><br><span>--- a/src/target/trx_toolkit/app_common.py</span><br><span>+++ b/src/target/trx_toolkit/app_common.py</span><br><span>@@ -40,19 +40,25 @@</span><br><span>                     "This is free software: you are free to change and redistribute it.\n" \</span><br><span>                   "There is NO WARRANTY, to the extent permitted by law.\n")</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      def add_log_handler(self, lh, log_level, log_fmt):</span><br><span style="color: hsl(120, 100%, 40%);">+            lf = log.Formatter(log_fmt)</span><br><span style="color: hsl(120, 100%, 40%);">+           ll = log.getLevelName(log_level)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+            log.root.addHandler(lh)</span><br><span style="color: hsl(120, 100%, 40%);">+               lh.setFormatter(lf)</span><br><span style="color: hsl(120, 100%, 40%);">+           lh.setLevel(ll)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    def app_init_logging(self, argv):</span><br><span>            # Default logging handler (stderr)</span><br><span style="color: hsl(0, 100%, 40%);">-              sh = log.StreamHandler()</span><br><span style="color: hsl(0, 100%, 40%);">-                sh.setLevel(log.getLevelName(argv.log_level))</span><br><span style="color: hsl(0, 100%, 40%);">-           sh.setFormatter(log.Formatter(argv.log_fmt))</span><br><span style="color: hsl(0, 100%, 40%);">-            log.root.addHandler(sh)</span><br><span style="color: hsl(120, 100%, 40%);">+               lo = (argv.log_level, argv.log_fmt)</span><br><span style="color: hsl(120, 100%, 40%);">+           lh = log.StreamHandler()</span><br><span style="color: hsl(120, 100%, 40%);">+              self.add_log_handler(lh, *lo)</span><br><span> </span><br><span>            # Optional file handler</span><br><span>              if argv.log_file_name is not None:</span><br><span style="color: hsl(0, 100%, 40%);">-                      fh = log.FileHandler(argv.log_file_name)</span><br><span style="color: hsl(0, 100%, 40%);">-                        fh.setLevel(log.getLevelName(argv.log_file_level))</span><br><span style="color: hsl(0, 100%, 40%);">-                      fh.setFormatter(log.Formatter(argv.log_file_fmt))</span><br><span style="color: hsl(0, 100%, 40%);">-                       log.root.addHandler(fh)</span><br><span style="color: hsl(120, 100%, 40%);">+                       lo = (argv.log_file_level, argv.log_file_fmt)</span><br><span style="color: hsl(120, 100%, 40%);">+                 lh = log.FileHandler(argv.log_file_name)</span><br><span style="color: hsl(120, 100%, 40%);">+                      self.add_log_handler(lh, *lo)</span><br><span> </span><br><span>            # Set DEBUG for the root logger</span><br><span>              log.root.setLevel(log.DEBUG)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17759">change 17759</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/17759"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ied32764cf1c34dc7e0f746f4f085ea20168775cb </div>
<div style="display:none"> Gerrit-Change-Number: 17759 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>