<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-iuh/+/17745">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/test-helpers: fix some -Wpointer-sign warnings reported by GCC<br><br>Change-Id: I7ebc99fe919fe7ba515c9d8ba601dceb820bf11f<br>---<br>M src/tests/test-helpers.c<br>1 file changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tests/test-helpers.c b/src/tests/test-helpers.c</span><br><span>index f218a79..d7ad758 100644</span><br><span>--- a/src/tests/test-helpers.c</span><br><span>+++ b/src/tests/test-helpers.c</span><br><span>@@ -64,12 +64,12 @@</span><br><span> const uint32_t val1 = 0xdeadbeef;</span><br><span> </span><br><span> const OCTET_STRING_t text1 = {</span><br><span style="color: hsl(0, 100%, 40%);">- .buf = "0123456789012345",</span><br><span style="color: hsl(120, 100%, 40%);">+ .buf = (uint8_t *) "0123456789012345",</span><br><span> .size = 16,</span><br><span> };</span><br><span> </span><br><span> const OCTET_STRING_t text2 = {</span><br><span style="color: hsl(0, 100%, 40%);">- .buf = "01234567890123456789012345678901234567890",</span><br><span style="color: hsl(120, 100%, 40%);">+ .buf = (uint8_t *) "01234567890123456789012345678901234567890",</span><br><span> .size = 40,</span><br><span> };</span><br><span> </span><br><span>@@ -145,9 +145,9 @@</span><br><span> </span><br><span> printf("Testing ranap common functions\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("PLMN-Id [ %s]", osmo_hexdump((char*)lai.pLMNidentity.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PLMN-Id [ %s]", osmo_hexdump(lai.pLMNidentity.buf,</span><br><span> lai.pLMNidentity.size));</span><br><span style="color: hsl(0, 100%, 40%);">- printf(", LAC [ %s]\n", osmo_hexdump((char*)lai.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf(", LAC [ %s]\n", osmo_hexdump(lai.lAC.buf,</span><br><span> lai.lAC.size));</span><br><span> </span><br><span> rc = ranap_parse_lai(&ra_id, &lai);</span><br><span>@@ -164,9 +164,9 @@</span><br><span> uint8_t plmnid_buf_mnc3[] = { 0x21, 0x43, 0x65 };</span><br><span> lai.pLMNidentity.buf = plmnid_buf_mnc3;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("PLMN-Id [ %s]", osmo_hexdump((char*)lai.pLMNidentity.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PLMN-Id [ %s]", osmo_hexdump(lai.pLMNidentity.buf,</span><br><span> lai.pLMNidentity.size));</span><br><span style="color: hsl(0, 100%, 40%);">- printf(", LAC [ %s]\n", osmo_hexdump((char*)lai.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf(", LAC [ %s]\n", osmo_hexdump(lai.lAC.buf,</span><br><span> lai.lAC.size));</span><br><span> </span><br><span> rc = ranap_parse_lai(&ra_id, &lai);</span><br><span>@@ -182,9 +182,9 @@</span><br><span> /* wrong PLMN-Id size */</span><br><span> lai.pLMNidentity.size = 2;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("PLMN-Id [ %s]", osmo_hexdump((char*)lai.pLMNidentity.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PLMN-Id [ %s]", osmo_hexdump(lai.pLMNidentity.buf,</span><br><span> lai.pLMNidentity.size));</span><br><span style="color: hsl(0, 100%, 40%);">- printf(", LAC [ %s]\n", osmo_hexdump((char*)lai.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf(", LAC [ %s]\n", osmo_hexdump(lai.lAC.buf,</span><br><span> lai.lAC.size));</span><br><span> </span><br><span> rc = ranap_parse_lai(&ra_id, &lai);</span><br><span>@@ -196,9 +196,9 @@</span><br><span> lai.pLMNidentity.size = 3;</span><br><span> lai.lAC.size = 1;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("PLMN-Id [ %s]", osmo_hexdump((char*)lai.pLMNidentity.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PLMN-Id [ %s]", osmo_hexdump(lai.pLMNidentity.buf,</span><br><span> lai.pLMNidentity.size));</span><br><span style="color: hsl(0, 100%, 40%);">- printf(", LAC [ %s]\n", osmo_hexdump((char*)lai.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ printf(", LAC [ %s]\n", osmo_hexdump(lai.lAC.buf,</span><br><span> lai.lAC.size));</span><br><span> </span><br><span> rc = ranap_parse_lai(&ra_id, &lai);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-iuh/+/17745">change 17745</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-iuh/+/17745"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7ebc99fe919fe7ba515c9d8ba601dceb820bf11f </div>
<div style="display:none"> Gerrit-Change-Number: 17745 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>