<p style="white-space: pre-wrap; word-wrap: break-word;">What about enabling the gprs egprs-packet-channel-request (set it  to 1) by default if one enables gprs mode egprs? Of course in a follow-up patch.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h">File include/osmocom/bsc/rest_octets.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace">    bool ctrl_ack_type_use_block; /* use PACKET CONTROL ACKNOWLEDGMENT */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This one seems duplicated too?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/src/osmo-bsc/bsc_vty.c">File src/osmo-bsc/bsc_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/src/osmo-bsc/bsc_vty.c@3184">Patch Set #1, Line 3184:</a> <code style="font-family:monospace,monospace"> if (bts->gprs.mode != BTS_GPRS_EGPRS) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this really make sense here? You are deactivating it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730">change 17730</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/17730"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ied5bd10a806aeeac65ef32339d4ab0e3700e5da9 </div>
<div style="display:none"> Gerrit-Change-Number: 17730 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Apr 2020 12:20:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>