<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17728">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: 'gprs 11bit_rach_support_for_egprs': drop redundant check<br><br>The VTY command parser would not allow values other than 0 or 1.<br><br>Change-Id: Ic29fac12414f1821702759a9f5260e941c9868b5<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 1 insertion(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/17728/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index a41db9f..cd3f8a9 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -3137,13 +3137,7 @@</span><br><span> </span><br><span>       bts->gprs.supports_egprs_11bit_rach = atoi(argv[0]);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (bts->gprs.supports_egprs_11bit_rach > 1) {</span><br><span style="color: hsl(0, 100%, 40%);">-            vty_out(vty, "Error in RACH type%s", VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-            return CMD_WARNING;</span><br><span style="color: hsl(0, 100%, 40%);">-     }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       if ((bts->gprs.mode == BTS_GPRS_NONE) &&</span><br><span style="color: hsl(0, 100%, 40%);">-             (bts->gprs.supports_egprs_11bit_rach == 1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (bts->gprs.mode == BTS_GPRS_NONE && bts->gprs.supports_egprs_11bit_rach) {</span><br><span>          vty_out(vty, "Error:gprs mode is none and 11bit rach is"</span><br><span>                   " enabled%s", VTY_NEWLINE);</span><br><span>                return CMD_WARNING;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17728">change 17728</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/17728"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic29fac12414f1821702759a9f5260e941c9868b5 </div>
<div style="display:none"> Gerrit-Change-Number: 17728 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>