<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17698">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">remove 'NAT' log category<br><br>This dates back to a time where osmo-bsc_nat was in the same repository,<br>which is a long time ago.<br><br>Change-Id: Id965295dfe04f8bd5ce831db70c86f67b8dc290b<br>---<br>M include/osmocom/bsc/debug.h<br>M src/libfilter/bsc_msg_acc.c<br>M src/osmo-bsc/osmo_bsc_main.c<br>M tests/bsc/bsc_test.c<br>4 files changed, 2 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/debug.h b/include/osmocom/bsc/debug.h</span><br><span>index adc6abb..82c0703 100644</span><br><span>--- a/include/osmocom/bsc/debug.h</span><br><span>+++ b/include/osmocom/bsc/debug.h</span><br><span>@@ -19,7 +19,6 @@</span><br><span>         DHO,</span><br><span>         DHODEC,</span><br><span>      DREF,</span><br><span style="color: hsl(0, 100%, 40%);">-   DNAT,</span><br><span>        DCTRL,</span><br><span>       DFILTER,</span><br><span>     DPCU,</span><br><span>diff --git a/src/libfilter/bsc_msg_acc.c b/src/libfilter/bsc_msg_acc.c</span><br><span>index de6c4d9..8853dbb 100644</span><br><span>--- a/src/libfilter/bsc_msg_acc.c</span><br><span>+++ b/src/libfilter/bsc_msg_acc.c</span><br><span>@@ -96,7 +96,7 @@</span><br><span> </span><br><span>       lst = talloc_zero(ctx, struct bsc_msg_acc_lst);</span><br><span>      if (!lst) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGP(DNAT, LOGL_ERROR, "Failed to allocate access list\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGP(DFILTER, LOGL_ERROR, "Failed to allocate access list\n");</span><br><span>             return NULL;</span><br><span>         }</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index bf68c9b..de84060 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -748,11 +748,6 @@</span><br><span>            .description = "Reference Counting",</span><br><span>               .enabled = 0, .loglevel = LOGL_NOTICE,</span><br><span>       },</span><br><span style="color: hsl(0, 100%, 40%);">-      [DNAT] = {</span><br><span style="color: hsl(0, 100%, 40%);">-              .name = "DNAT",</span><br><span style="color: hsl(0, 100%, 40%);">-               .description = "GSM 08.08 NAT/Multiplexer",</span><br><span style="color: hsl(0, 100%, 40%);">-           .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-  },</span><br><span>   [DCTRL] = {</span><br><span>          .name = "DCTRL",</span><br><span>           .description = "Control interface",</span><br><span>@@ -915,7 +910,7 @@</span><br><span> </span><br><span>      llist_for_each_entry(msc, &bsc_gsmnet->bsc_data->mscs, entry) {</span><br><span>            if (osmo_bsc_msc_init(msc) != 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      LOGP(DNAT, LOGL_ERROR, "Failed to start up. Exiting.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOGP(DMSC, LOGL_ERROR, "Failed to start up. Exiting.\n");</span><br><span>                  exit(1);</span><br><span>             }</span><br><span>    }</span><br><span>diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c</span><br><span>index 86b7282..6079ec5 100644</span><br><span>--- a/tests/bsc/bsc_test.c</span><br><span>+++ b/tests/bsc/bsc_test.c</span><br><span>@@ -192,11 +192,6 @@</span><br><span>                .color = "\033[1;36m",</span><br><span>             .enabled = 1, .loglevel = LOGL_INFO,</span><br><span>         },</span><br><span style="color: hsl(0, 100%, 40%);">-      [DNAT] = {</span><br><span style="color: hsl(0, 100%, 40%);">-              .name = "DNAT",</span><br><span style="color: hsl(0, 100%, 40%);">-               .description = "GSM 08.08 NAT/Multiplexer",</span><br><span style="color: hsl(0, 100%, 40%);">-           .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-  },</span><br><span>   [DMSC] = {</span><br><span>           .name = "DMSC",</span><br><span>            .description = "Mobile Switching Center",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17698">change 17698</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/17698"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id965295dfe04f8bd5ce831db70c86f67b8dc290b </div>
<div style="display:none"> Gerrit-Change-Number: 17698 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>