<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17697">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use read_binary function of card class to read GID2 and reduce code duplication<br><br>Change-Id: I5d80fcc1446a6691b8e2a09bcec558148fa31ab2<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>2 files changed, 1 insertion(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index cd82498..f167bce 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -124,7 +124,7 @@</span><br><span> </span><br><span>         # EF.GID2</span><br><span>    try:</span><br><span style="color: hsl(0, 100%, 40%);">-            (res, sw) = card.read_gid2()</span><br><span style="color: hsl(120, 100%, 40%);">+          (res, sw) = card.read_binary('GID2')</span><br><span>                 if sw == '9000':</span><br><span>                     print("GID2: %s" % (res,))</span><br><span>                 else:</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index c702608..d3b6262 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -160,13 +160,6 @@</span><br><span>            else:</span><br><span>                        return (None, sw)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   def read_gid2(self):</span><br><span style="color: hsl(0, 100%, 40%);">-            (res, sw) = self._scc.read_binary(EF['GID2'])</span><br><span style="color: hsl(0, 100%, 40%);">-           if sw == '9000':</span><br><span style="color: hsl(0, 100%, 40%);">-                        return (res, sw)</span><br><span style="color: hsl(0, 100%, 40%);">-                else:</span><br><span style="color: hsl(0, 100%, 40%);">-                   return (None, sw)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    # Read the (full) AID for either ISIM or USIM application</span><br><span>    def read_aid(self, isim = False):</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17697">change 17697</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17697"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5d80fcc1446a6691b8e2a09bcec558148fa31ab2 </div>
<div style="display:none"> Gerrit-Change-Number: 17697 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>