<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17663">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Move parsing of HPLMNAcT to generic Card class<br><br>Change-Id: I46c863c118dcbef89455c34289ed25e5a342f35b<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>2 files changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index 4446987..f54045b 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -183,9 +183,9 @@</span><br><span> </span><br><span>         # EF.HPLMNAcT</span><br><span>        try:</span><br><span style="color: hsl(0, 100%, 40%);">-            (res, sw) = scc.read_binary(EF['HPLMNAcT'])</span><br><span style="color: hsl(120, 100%, 40%);">+           (res, sw) = card.read_hplmn_act()</span><br><span>            if sw == '9000':</span><br><span style="color: hsl(0, 100%, 40%);">-                        print("HPLMNAcT:\n%s" % (format_xplmn_w_act(res)))</span><br><span style="color: hsl(120, 100%, 40%);">+                  print("HPLMNAcT:\n%s" % (res))</span><br><span>             else:</span><br><span>                        print("HPLMNAcT: Can't read, response code = %s" % (sw,))</span><br><span>      except Exception as e:</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 55d1979..8081f87 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -66,6 +66,13 @@</span><br><span>             data, sw = self._scc.update_binary(EF['ACC'], lpad(acc, 4))</span><br><span>          return sw</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def read_hplmn_act(self):</span><br><span style="color: hsl(120, 100%, 40%);">+             (res, sw) = self._scc.read_binary(EF['HPLMNAcT'])</span><br><span style="color: hsl(120, 100%, 40%);">+             if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+                      return (format_xplmn_w_act(res), sw)</span><br><span style="color: hsl(120, 100%, 40%);">+          else:</span><br><span style="color: hsl(120, 100%, 40%);">+                 return (None, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  def update_hplmn_act(self, mcc, mnc, access_tech='FFFF'):</span><br><span>            """</span><br><span>           Update Home PLMN with access technology bit-field</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17663">change 17663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I46c863c118dcbef89455c34289ed25e5a342f35b </div>
<div style="display:none"> Gerrit-Change-Number: 17663 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>