<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17661">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Move parsing of PLMNwAcT to generic Card class<br><br>Change-Id: I14d7c2dc51fac6d5cf4a708a77ad23d252ba6094<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>2 files changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index d62cdd3..5229dda 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -163,9 +163,9 @@</span><br><span> </span><br><span>         # EF.PLMNwAcT</span><br><span>        try:</span><br><span style="color: hsl(0, 100%, 40%);">-            (res, sw) = scc.read_binary(EF['PLMNwAcT'])</span><br><span style="color: hsl(120, 100%, 40%);">+           (res, sw) = card.read_plmn_act()</span><br><span>             if sw == '9000':</span><br><span style="color: hsl(0, 100%, 40%);">-                        print("PLMNwAcT:\n%s" % (format_xplmn_w_act(res)))</span><br><span style="color: hsl(120, 100%, 40%);">+                  print("PLMNwAcT:\n%s" % (res))</span><br><span>             else:</span><br><span>                        print("PLMNwAcT: Can't read, response code = %s" % (sw,))</span><br><span>      except Exception as e:</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index d3b6262..16f6881 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -96,6 +96,13 @@</span><br><span>             data, sw = self._scc.update_binary(EF['OPLMNwAcT'], content + 'ffffff0000' * (size // 5 - 1))</span><br><span>                return sw</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def read_plmn_act(self):</span><br><span style="color: hsl(120, 100%, 40%);">+              (res, sw) = self._scc.read_binary(EF['PLMNwAcT'])</span><br><span style="color: hsl(120, 100%, 40%);">+             if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+                      return (format_xplmn_w_act(res), sw)</span><br><span style="color: hsl(120, 100%, 40%);">+          else:</span><br><span style="color: hsl(120, 100%, 40%);">+                 return (None, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  def update_plmn_act(self, mcc, mnc, access_tech='FFFF'):</span><br><span>             """</span><br><span>           See note in update_hplmn_act()</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17661">change 17661</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17661"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I14d7c2dc51fac6d5cf4a708a77ad23d252ba6094 </div>
<div style="display:none"> Gerrit-Change-Number: 17661 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>