<p>Patch set 8:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/src/osmo_gsm_tester/iperf3.py">File src/osmo_gsm_tester/iperf3.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/src/osmo_gsm_tester/iperf3.py@159">Patch Set #8, Line 159:</a> <code style="font-family:monospace,monospace">            values = dict(iperf3cli=config.get_defaults('iperf3cli'))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You acked my commit but didn't apply the change :)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/src/osmo_gsm_tester/iperf3.py@171">Patch Set #8, Line 171:</a> <code style="font-family:monospace,monospace">            time_sec_final = int(time_sec)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If coming from argument, then it should be an integer, so having time_sec_final = time_sec should be enough here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_dl.py">File suites/4g/iperf3_dl.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_dl.py@35">Patch Set #8, Line 35:</a> <code style="font-family:monospace,monospace">proc = iperf3cli.prepare_test_proc(True, ue.netns(), time_sec=None)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">simply remove the time_sec=None from here, default will apply.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_ul.py">File suites/4g/iperf3_ul.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_ul.py@35">Patch Set #8, Line 35:</a> <code style="font-family:monospace,monospace">proc = iperf3cli.prepare_test_proc(False, ue.netns(), time_sec=None)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">simply remove the time_sec=None from here, default will apply.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651">change 17651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d </div>
<div style="display:none"> Gerrit-Change-Number: 17651 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 01 Apr 2020 11:26:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>