<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS: fix as_l1_count_paging(): do not count PCH filling messages<br><br>Since build #842, both TC_paging_{i|t}msi_80percent started to fail:<br><br>  "BTS_Tests.ttcn:3051 : Expected 271 pagings but have 284"<br>      BTS_Tests.ttcn:6414 BTS_Tests control part<br>      BTS_Tests.ttcn:3051 TC_paging_imsi_80percent testcase<br><br>  "BTS_Tests.ttcn:3075 : Expected 543 pagings but have 553"<br>      BTS_Tests.ttcn:6415 BTS_Tests control part<br>      BTS_Tests.ttcn:3075 TC_paging_tmsi_80percent testcase<br><br>As it turns out, since If5339c7a91b4e0188194f1cd935798f153974e01<br>TITAN can decode PCH filling messages with no Mobile Identity.<br>We should not count them in as_l1_count_paging(), as they're<br>sent by osmo-bts itself.<br><br>Change-Id: I420f36ed000b1c2488fbe500c33a8161e27d20e3<br>Fixes: OS#4475<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/17683/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index a2b4af7..31c11fa 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -2866,7 +2866,9 @@</span><br><span> </span><br><span>              check_pch_fn(dl.dl_info.frame_nr, cfg.bs_ag_blks_res);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-              if (match(rr, tr_PAGING_REQ1)) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (match(rr, tr_PAGING_REQ1(tr_MI_LV(t_MI_NoIdentity(?))))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* Ignore rmpty RR Paging Request (PCH filling) */</span><br><span style="color: hsl(120, 100%, 40%);">+            } else if (match(rr, tr_PAGING_REQ1)) {</span><br><span>                      num_paging_rcv_msgs := num_paging_rcv_msgs + 1;</span><br><span>                      num_paging_rcv_ids := num_paging_rcv_ids + 1;</span><br><span>                        if (ispresent(rr.msgs.rrm.pagingReq_Type1.mobileIdentity2)) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683">change 17683</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I420f36ed000b1c2488fbe500c33a8161e27d20e3 </div>
<div style="display:none"> Gerrit-Change-Number: 17683 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>