<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17631">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, approved
  osmith: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1: verify enough bits present to decode whole CSN_UINT_ARRAY<br><br>Change-Id: I4a762a8fec4153b53e10df1ec8ba3708c1f47649<br>---<br>M src/csn1.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.c b/src/csn1.c</span><br><span>index 1b3cc55..78444bb 100644</span><br><span>--- a/src/csn1.c</span><br><span>+++ b/src/csn1.c</span><br><span>@@ -338,7 +338,7 @@</span><br><span>           nCount = *pui16DATA(data, nCount);</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (remaining_bits_len >= no_of_bits)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (remaining_bits_len >= (no_of_bits * nCount))</span><br><span>         {</span><br><span>           remaining_bits_len -= (no_of_bits*nCount);</span><br><span>           if (no_of_bits <= 8)</span><br><span>@@ -781,7 +781,7 @@</span><br><span>               nCount = *pui16DATA(data, nCount);</span><br><span>             }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-            if (remaining_bits_len >= no_of_bits)</span><br><span style="color: hsl(120, 100%, 40%);">+            if (remaining_bits_len >= (no_of_bits * nCount))</span><br><span>             {</span><br><span>               remaining_bits_len -= (no_of_bits * nCount);</span><br><span>               if (no_of_bits <= 8)</span><br><span>@@ -1650,7 +1650,7 @@</span><br><span>           nCount = *pui16DATA(data, nCount);</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (remaining_bits_len >= no_of_bits)</span><br><span style="color: hsl(120, 100%, 40%);">+        if (remaining_bits_len >= (no_of_bits * nCount))</span><br><span>         {</span><br><span>           if (no_of_bits <= 8)</span><br><span>           {</span><br><span>@@ -2067,7 +2067,7 @@</span><br><span>               nCount = *pui16DATA(data, nCount);</span><br><span>             }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-            if (remaining_bits_len >= no_of_bits)</span><br><span style="color: hsl(120, 100%, 40%);">+            if (remaining_bits_len >= (no_of_bits * nCount))</span><br><span>             {</span><br><span>               if (no_of_bits <= 8)</span><br><span>               {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17631">change 17631</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17631"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4a762a8fec4153b53e10df1ec8ba3708c1f47649 </div>
<div style="display:none"> Gerrit-Change-Number: 17631 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>