<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17656">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/L3_Templates: remove tr_PAGING_REQ1_MI1_TMSI, use existing MI templates<br><br>Change-Id: Id35477ffc4a914e71100f129bbc4833b48ed5da4<br>---<br>M library/L3_Templates.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 4 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/17656/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn</span><br><span>index 092026e..46cd1ac 100644</span><br><span>--- a/library/L3_Templates.ttcn</span><br><span>+++ b/library/L3_Templates.ttcn</span><br><span>@@ -381,22 +381,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Template for receiving a Paging Request Type1 message with a given TMSI in the first mobile identity. */</span><br><span style="color: hsl(0, 100%, 40%);">-template MobileIdentityLV tr_PAGING_REQ1_MI1_TMSI(octetstring tmsi) := {</span><br><span style="color: hsl(0, 100%, 40%);">- lengthIndicator := 5,</span><br><span style="color: hsl(0, 100%, 40%);">- mobileIdentityV := {</span><br><span style="color: hsl(0, 100%, 40%);">- typeOfIdentity := '100'B,</span><br><span style="color: hsl(0, 100%, 40%);">- oddEvenInd_identity := {</span><br><span style="color: hsl(0, 100%, 40%);">- tmsi_ptmsi := {</span><br><span style="color: hsl(0, 100%, 40%);">- oddevenIndicator := '0'B,</span><br><span style="color: hsl(0, 100%, 40%);">- fillerDigit := '1111'B,</span><br><span style="color: hsl(0, 100%, 40%);">- octets := tmsi</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> template PDU_ML3_NW_MS tr_PAGING_REQ2(template TMSIP_TMSI_V mi1 := ?,</span><br><span> template TMSIP_TMSI_V mi2 := ?,</span><br><span> template MobileIdentityTLV mi3 := *) := {</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 1c2b271..7ef3d0a 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -222,7 +222,7 @@</span><br><span> log("BSSGP successfully initialized");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_wait_paging_req_type1(hexstring expected_tmsi) runs on dummy_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_wait_paging_req_type1(template (present) MobileIdentityV mi) runs on dummy_CT {</span><br><span> var LAPDm_ph_data ph_data;</span><br><span> timer T := 5.0;</span><br><span> </span><br><span>@@ -240,7 +240,7 @@</span><br><span> repeat;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (match(pdu, tr_PAGING_REQ1(tr_PAGING_REQ1_MI1_TMSI(hex2oct(expected_tmsi))))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (match(pdu, tr_PAGING_REQ1(tr_MI_LV(mi)))) {</span><br><span> setverdict(pass);</span><br><span> } else {</span><br><span> repeat;</span><br><span>@@ -268,12 +268,12 @@</span><br><span> /*</span><br><span> TODO: Paging by IMSI does not work yet because osmo-pcu does not copy IMSI into paging requests.</span><br><span> BSSGP_SIG[0].send(ts_BSSGP_PS_PAGING_IMSI(0, g_mmctx.imsi));</span><br><span style="color: hsl(0, 100%, 40%);">- f_wait_paging_req_type1(hex2oct(g_mmctx.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_wait_paging_req_type1(tr_MI_IMSI(g_mmctx.imsi));</span><br><span> */</span><br><span> </span><br><span> /* Page by TMSI */</span><br><span> BSSGP_SIG[0].send(ts_BSSGP_PS_PAGING_PTMSI(0, g_mmctx.imsi, tmsi));</span><br><span style="color: hsl(0, 100%, 40%);">- f_wait_paging_req_type1(tmsi_hex);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_wait_paging_req_type1(t_MI_TMSI(hex2oct(tmsi_hex)));</span><br><span> }</span><br><span> </span><br><span> /* Establish an UL TBF: Tune to ARFCN, send RACH, receive AGCH, enable TBF Rx */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17656">change 17656</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17656"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id35477ffc4a914e71100f129bbc4833b48ed5da4 </div>
<div style="display:none"> Gerrit-Change-Number: 17656 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>