<p>herlesupreeth has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17666">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Move parsing of AD to generic Card class<br><br>Change-Id: Ie7f62913caed95f482445962954857bb69b58078<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>2 files changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/17666/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index b84be29..468dadd 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -213,7 +213,7 @@</span><br><span>          print("MSISDN: Can't read file -- " + str(e))</span><br><span> </span><br><span>      # EF.AD</span><br><span style="color: hsl(0, 100%, 40%);">- (res, sw) = scc.read_binary(['3f00', '7f20', '6fad'])</span><br><span style="color: hsl(120, 100%, 40%);">+ (res, sw) = card.read_ad()</span><br><span>   if sw == '9000':</span><br><span>             print("AD: %s" % (res,))</span><br><span>   else:</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 06753c3..4141a79 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -161,6 +161,13 @@</span><br><span>            data, sw = self._scc.update_record(EF['SMSP'], 1, rpad(smsp, 84))</span><br><span>            return sw</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def read_ad(self):</span><br><span style="color: hsl(120, 100%, 40%);">+            (res, sw) = self._scc.read_binary(EF['AD'])</span><br><span style="color: hsl(120, 100%, 40%);">+           if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+                      return (res, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+              else:</span><br><span style="color: hsl(120, 100%, 40%);">+                 return (None, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  def update_ad(self, mnc):</span><br><span>            #See also: 3GPP TS 31.102, chapter 4.2.18</span><br><span>            mnclen = len(str(mnc))</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17666">change 17666</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17666"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie7f62913caed95f482445962954857bb69b58078 </div>
<div style="display:none"> Gerrit-Change-Number: 17666 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>