<p>herlesupreeth has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17662">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Move parsing of OPLMNwAcT to generic Card class<br><br>Change-Id: I8050bd103a7085b2631ddc4e567d15e05f9428f2<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>2 files changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/17662/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index ba4e882..0da00b5 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -173,9 +173,9 @@</span><br><span> </span><br><span>      # EF.OPLMNwAcT</span><br><span>       try:</span><br><span style="color: hsl(0, 100%, 40%);">-            (res, sw) = scc.read_binary(EF['OPLMNwAcT'])</span><br><span style="color: hsl(120, 100%, 40%);">+          (res, sw) = card.read_oplmn_act()</span><br><span>            if sw == '9000':</span><br><span style="color: hsl(0, 100%, 40%);">-                        print("OPLMNwAcT:\n%s" % (format_xplmn_w_act(res)))</span><br><span style="color: hsl(120, 100%, 40%);">+                 print("OPLMNwAcT:\n%s" % (res))</span><br><span>            else:</span><br><span>                        print("OPLMNwAcT: Can't read, response code = %s" % (sw,))</span><br><span>     except Exception as e:</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index b666f65..ac9d993 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -84,6 +84,13 @@</span><br><span>             data, sw = self._scc.update_binary(EF['HPLMNwAcT'], content + 'ffffff0000' * (size // 5 - 1))</span><br><span>                return sw</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def read_oplmn_act(self):</span><br><span style="color: hsl(120, 100%, 40%);">+             (res, sw) = self._scc.read_binary(EF['OPLMNwAcT'])</span><br><span style="color: hsl(120, 100%, 40%);">+            if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+                      return (format_xplmn_w_act(res), sw)</span><br><span style="color: hsl(120, 100%, 40%);">+          else:</span><br><span style="color: hsl(120, 100%, 40%);">+                 return (None, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  def update_oplmn_act(self, mcc, mnc, access_tech='FFFF'):</span><br><span>            """</span><br><span>           See note in update_hplmn_act()</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17662">change 17662</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17662"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8050bd103a7085b2631ddc4e567d15e05f9428f2 </div>
<div style="display:none"> Gerrit-Change-Number: 17662 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>