<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17643">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests_SMSCB: use existing tr_PAG_REQ1 and t_MI_NoIdentity<br><br>Change-Id: I018e1d875c85fe3958fd184fe0d2b0f56d1e343a<br>---<br>M bts/BTS_Tests_SMSCB.ttcn<br>1 file changed, 3 insertions(+), 29 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests_SMSCB.ttcn b/bts/BTS_Tests_SMSCB.ttcn</span><br><span>index ebd8d0f..08e1cef 100644</span><br><span>--- a/bts/BTS_Tests_SMSCB.ttcn</span><br><span>+++ b/bts/BTS_Tests_SMSCB.ttcn</span><br><span>@@ -23,6 +23,7 @@</span><br><span> import from LAPDm_Types all;</span><br><span> import from IPA_Emulation all;</span><br><span> import from GSM_RR_Types all;</span><br><span style="color: hsl(120, 100%, 40%);">+import from L3_Templates all;</span><br><span> </span><br><span> import from RSL_Types all;</span><br><span> </span><br><span>@@ -884,33 +885,6 @@</span><br><span> payload :=?</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private template GsmRrMessage tr_PagingType1_empty := {</span><br><span style="color: hsl(0, 100%, 40%);">- header := t_RrHeader(PAGING_REQUEST_TYPE_1, 5),</span><br><span style="color: hsl(0, 100%, 40%);">- payload := {</span><br><span style="color: hsl(0, 100%, 40%);">- pag_req_1 := {</span><br><span style="color: hsl(0, 100%, 40%);">- chan_needed := {</span><br><span style="color: hsl(0, 100%, 40%);">- second := CHAN_NEED_ANY,</span><br><span style="color: hsl(0, 100%, 40%);">- first := CHAN_NEED_ANY</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span style="color: hsl(0, 100%, 40%);">- page_mode := PAGE_MODE_NORMAL,</span><br><span style="color: hsl(0, 100%, 40%);">- mi1 := {</span><br><span style="color: hsl(0, 100%, 40%);">- lengthIndicator := 1,</span><br><span style="color: hsl(0, 100%, 40%);">- mobileIdentityV := {</span><br><span style="color: hsl(0, 100%, 40%);">- typeOfIdentity := '000'B,</span><br><span style="color: hsl(0, 100%, 40%);">- oddEvenInd_identity := {</span><br><span style="color: hsl(0, 100%, 40%);">- no_identity := {</span><br><span style="color: hsl(0, 100%, 40%);">- oddevenIndicator := '0'B,</span><br><span style="color: hsl(0, 100%, 40%);">- fillerDigits := 'F'H</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span style="color: hsl(0, 100%, 40%);">- mi2 := omit,</span><br><span style="color: hsl(0, 100%, 40%);">- rest_octets := ?</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* we expect four blocks of 14 bytes, let's fill them with content easily distinguishable */</span><br><span> const octetstring c_etws_seg0 := '000102030405060708090a0b0c0d'O;</span><br><span> const octetstring c_etws_seg1 := '101112131415161718191a1b1c1d'O;</span><br><span>@@ -941,7 +915,7 @@</span><br><span> [] L1CTL.receive(tr_L1CTL_DATA_IND(t_chan_nr)) -> value dl {</span><br><span> var GsmRrMessage l3 := dec_GsmRrMessage(dl.payload.data_ind.payload);</span><br><span> select (l3) {</span><br><span style="color: hsl(0, 100%, 40%);">- case (tr_PagingType1_empty) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case (tr_PAG_REQ1(tr_MI_LV(t_MI_NoIdentity()))) {</span><br><span> var octetstring p1ro := l3.payload.pag_req_1.rest_octets;</span><br><span> var bitstring midamble := oct2bit(substr(p1ro, 0, 3));</span><br><span> var octetstring segment := substr(p1ro, 3, lengthof(p1ro)-3);</span><br><span>@@ -1037,7 +1011,7 @@</span><br><span> [] L1CTL.receive(tr_L1CTL_DATA_IND(t_chan_nr)) -> value dl {</span><br><span> var GsmRrMessage l3 := dec_GsmRrMessage(dl.payload.data_ind.payload);</span><br><span> select (l3) {</span><br><span style="color: hsl(0, 100%, 40%);">- case (tr_PagingType1_empty) { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ case (tr_PAG_REQ1(tr_MI_LV(t_MI_NoIdentity()))) { repeat; }</span><br><span> case (tr_PagingType1) {</span><br><span> setverdict(fail, "Received non-empty PT1 after disabling ETWS PN: ", l3);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17643">change 17643</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17643"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I018e1d875c85fe3958fd184fe0d2b0f56d1e343a </div>
<div style="display:none"> Gerrit-Change-Number: 17643 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>