<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17636">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">VTY: let all descriptions end in \n<br><br>Change-Id: I00a183078679db50567286a78c9e4f9afa3466c6<br>---<br>M src/osmo-bsc/abis_nm_vty.c<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/osmo_bsc_vty.c<br>3 files changed, 18 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm_vty.c b/src/osmo-bsc/abis_nm_vty.c</span><br><span>index b1c6d56..fe467fa 100644</span><br><span>--- a/src/osmo-bsc/abis_nm_vty.c</span><br><span>+++ b/src/osmo-bsc/abis_nm_vty.c</span><br><span>@@ -165,7 +165,7 @@</span><br><span> }</span><br><span> </span><br><span> DEFUN(oml_opstart, oml_opstart_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">- "opstart", "Send an OPSTART message to the object")</span><br><span style="color: hsl(120, 100%, 40%);">+ "opstart", "Send an OPSTART message to the object\n")</span><br><span> {</span><br><span> struct oml_node_state *oms = vty->index;</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index e9085b3..a41db9f 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -536,7 +536,7 @@</span><br><span> </span><br><span> DEFUN(show_bts, show_bts_cmd, "show bts [<0-255>]",</span><br><span> SHOW_STR "Display information about a BTS\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "BTS number")</span><br><span style="color: hsl(120, 100%, 40%);">+ "BTS number\n")</span><br><span> {</span><br><span> struct gsm_network *net = gsmnet_from_vty(vty);</span><br><span> int bts_nr;</span><br><span>@@ -2560,7 +2560,7 @@</span><br><span> "ccch load-indication-threshold <0-100>",</span><br><span> CCCH_STR</span><br><span> "Percentage of CCCH load at which BTS sends RSL CCCH LOAD IND\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "CCCH Load Threshold in percent (Default: 10)")</span><br><span style="color: hsl(120, 100%, 40%);">+ "CCCH Load Threshold in percent (Default: 10)\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> bts->ccch_load_ind_thresh = atoi(argv[0]);</span><br><span>@@ -2575,7 +2575,7 @@</span><br><span> RACH_STR NM_STR</span><br><span> "Set the NM Busy Threshold\n"</span><br><span> "Set the NM Busy Threshold\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "NM Busy Threshold in dB")</span><br><span style="color: hsl(120, 100%, 40%);">+ "NM Busy Threshold in dB\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> bts->rach_b_thresh = atoi(argv[0]);</span><br><span>@@ -2679,7 +2679,7 @@</span><br><span> "MS Options\n"</span><br><span> "Maximum transmit power of the MS\n"</span><br><span> "Maximum transmit power of the MS\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Maximum transmit power of the MS in dBm")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Maximum transmit power of the MS in dBm\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2694,7 +2694,7 @@</span><br><span> "cell reselection hysteresis <0-14>",</span><br><span> CELL_STR "Cell re-selection parameters\n"</span><br><span> "Cell Re-Selection Hysteresis in dB\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Cell Re-Selection Hysteresis in dB")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Cell Re-Selection Hysteresis in dB\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2708,7 +2708,7 @@</span><br><span> "Minimum RxLev needed for cell access\n"</span><br><span> "Minimum RxLev needed for cell access\n"</span><br><span> "Minimum RxLev needed for cell access\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Minimum RxLev needed for cell access (better than -110dBm)")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Minimum RxLev needed for cell access (better than -110dBm)\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2749,7 +2749,7 @@</span><br><span> "temporary offset <0-60>",</span><br><span> "Cell selection temporary negative offset\n"</span><br><span> "Cell selection temporary negative offset\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Cell selection temporary negative offset in dB")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Cell selection temporary negative offset in dB\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2763,7 +2763,7 @@</span><br><span> "temporary offset infinite",</span><br><span> "Cell selection temporary negative offset\n"</span><br><span> "Cell selection temporary negative offset\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Sets cell selection temporary negative offset to infinity")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Sets cell selection temporary negative offset to infinity\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2793,7 +2793,7 @@</span><br><span> "Cell selection penalty time\n"</span><br><span> "Set cell selection penalty time to reserved value 31, "</span><br><span> "(indicate that CELL_RESELECT_OFFSET is subtracted from C2 "</span><br><span style="color: hsl(0, 100%, 40%);">- "and TEMPORARY_OFFSET is ignored)")</span><br><span style="color: hsl(120, 100%, 40%);">+ "and TEMPORARY_OFFSET is ignored)\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2840,7 +2840,7 @@</span><br><span> GPRS_TEXT</span><br><span> "GPRS Cell Settings\n"</span><br><span> "GPRS BSSGP VC Identifier\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "GPRS BSSGP VC Identifier")</span><br><span style="color: hsl(120, 100%, 40%);">+ "GPRS BSSGP VC Identifier\n")</span><br><span> {</span><br><span> /* ETSI TS 101 343: values 0 and 1 are reserved for signalling and PTM */</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span>@@ -2859,7 +2859,7 @@</span><br><span> "gprs nsei <0-65535>",</span><br><span> GPRS_TEXT</span><br><span> "GPRS NS Entity Identifier\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "GPRS NS Entity Identifier")</span><br><span style="color: hsl(120, 100%, 40%);">+ "GPRS NS Entity Identifier\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -2880,7 +2880,7 @@</span><br><span> "gprs nsvc <0-1> nsvci <0-65535>",</span><br><span> GPRS_TEXT NSVC_TEXT</span><br><span> "NS Virtual Connection Identifier\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "GPRS NS VC Identifier")</span><br><span style="color: hsl(120, 100%, 40%);">+ "GPRS NS VC Identifier\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> int idx = atoi(argv[0]);</span><br><span>@@ -3131,7 +3131,7 @@</span><br><span> "gprs 11bit_rach_support_for_egprs (0|1)",</span><br><span> GPRS_TEXT "11 bit RACH options\n"</span><br><span> "Disable 11 bit RACH for EGPRS\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "Enable 11 bit RACH for EGPRS")</span><br><span style="color: hsl(120, 100%, 40%);">+ "Enable 11 bit RACH for EGPRS\n")</span><br><span> {</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span> </span><br><span>@@ -4200,8 +4200,8 @@</span><br><span> DEFUN(cfg_trx,</span><br><span> cfg_trx_cmd,</span><br><span> "trx <0-255>",</span><br><span style="color: hsl(0, 100%, 40%);">- TRX_TEXT</span><br><span style="color: hsl(0, 100%, 40%);">- "Select a TRX to configure")</span><br><span style="color: hsl(120, 100%, 40%);">+ TRX_TEXT</span><br><span style="color: hsl(120, 100%, 40%);">+ "Select a TRX to configure\n")</span><br><span> {</span><br><span> int trx_nr = atoi(argv[0]);</span><br><span> struct gsm_bts *bts = vty->index;</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c</span><br><span>index e656d70..c372b48 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_vty.c</span><br><span>@@ -539,7 +539,7 @@</span><br><span> cfg_msc_acc_lst_name_cmd,</span><br><span> "access-list-name NAME",</span><br><span> "Set the name of the access list to use.\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "The name of the to be used access list.")</span><br><span style="color: hsl(120, 100%, 40%);">+ "The name of the to be used access list.\n")</span><br><span> {</span><br><span> struct bsc_msc_data *msc = bsc_msc_data(vty);</span><br><span> </span><br><span>@@ -792,7 +792,7 @@</span><br><span> cfg_bsc_acc_lst_name_cmd,</span><br><span> "access-list-name NAME",</span><br><span> "Set the name of the access list to use.\n"</span><br><span style="color: hsl(0, 100%, 40%);">- "The name of the to be used access list.")</span><br><span style="color: hsl(120, 100%, 40%);">+ "The name of the to be used access list.\n")</span><br><span> {</span><br><span> struct osmo_bsc_data *bsc = osmo_bsc_data(vty);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/17636">change 17636</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/17636"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00a183078679db50567286a78c9e4f9afa3466c6 </div>
<div style="display:none"> Gerrit-Change-Number: 17636 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>