<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17625">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf.cpp: Include c++ <new> header required for new operator's replacement type<br><br>Including the <new> header is required as explained by the c++ specs [1]<br><br>osmo-pcu/src/tbf.cpp: In function ‘gprs_rlcmac_ul_tbf* tbf_alloc_ul_tbf(gprs_rlcmac_bts*, GprsMs*, int8_t, uint8_t, uint8_t, bool)’:<br>osmo-pcu/src/tbf.cpp:1002:39: error: no matching function for call to ‘operator new(sizetype, gprs_rlcmac_ul_tbf*&)’<br> 1002 |  new (tbf) gprs_rlcmac_ul_tbf(bts->bts);<br>      |                                       ^<br><br>Most of the times this issue is not detected because other STL headers<br>are already including <new>.<br><br>[1] http://www.cplusplus.com/reference/new/operator%20new/<br><br>Change-Id: Ie5fb536ae29dcf40e2a0dbe67432bebd61b8c7aa<br>---<br>M src/tbf.cpp<br>M tests/ms/MsTest.cpp<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/25/17625/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 444cec0..9cba354 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -19,6 +19,8 @@</span><br><span>  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <new></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #include <bts.h></span><br><span> #include <tbf.h></span><br><span> #include <tbf_dl.h></span><br><span>diff --git a/tests/ms/MsTest.cpp b/tests/ms/MsTest.cpp</span><br><span>index 0c5ab9e..b5e30fb 100644</span><br><span>--- a/tests/ms/MsTest.cpp</span><br><span>+++ b/tests/ms/MsTest.cpp</span><br><span>@@ -40,6 +40,8 @@</span><br><span> #include <errno.h></span><br><span> #include <unistd.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <new></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void *tall_pcu_ctx;</span><br><span> int16_t spoof_mnc = 0, spoof_mcc = 0;</span><br><span> bool spoof_mnc_3_digits = false;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17625">change 17625</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17625"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie5fb536ae29dcf40e2a0dbe67432bebd61b8c7aa </div>
<div style="display:none"> Gerrit-Change-Number: 17625 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>