<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17629">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rlcmac: add dissection of 2G->3G/4G PS handover<br><br>Port from wireshark.git 428ee66ae1c524b49f9043729b1f1e9b4f52f409, from<br>Pascal Quantin.<br><br>The original commit is also changing the RRC_Container field to<br>M_CALLBACK, but we leave them as M_VAR_ARRAY since the callback is<br>basically used to add more dissection information in wireshark.<br><br>Change-Id: I0f374e78300efddff00c4df26a401adcdee18a12<br>---<br>M src/gsm_rlcmac.c<br>M src/gsm_rlcmac.h<br>2 files changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/17629/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm_rlcmac.c b/src/gsm_rlcmac.c</span><br><span>index b421624..9b5ecfe 100644</span><br><span>--- a/src/gsm_rlcmac.c</span><br><span>+++ b/src/gsm_rlcmac.c</span><br><span>@@ -4574,6 +4574,12 @@</span><br><span> </span><br><span> </span><br><span> static const</span><br><span style="color: hsl(120, 100%, 40%);">+CSN_DESCR_BEGIN(PS_HandoverTo_E_UTRAN_Payload_t)</span><br><span style="color: hsl(120, 100%, 40%);">+  M_UINT       (PS_HandoverTo_E_UTRAN_Payload_t, RRC_ContainerLength, 8),</span><br><span style="color: hsl(120, 100%, 40%);">+  M_VAR_ARRAY  (PS_HandoverTo_E_UTRAN_Payload_t, RRC_Container, RRC_ContainerLength, 0),</span><br><span style="color: hsl(120, 100%, 40%);">+CSN_DESCR_END  (PS_HandoverTo_E_UTRAN_Payload_t)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const</span><br><span> CSN_DESCR_BEGIN(PHO_RadioResources_t)</span><br><span>   M_NEXT_EXIST (PHO_RadioResources_t, Exist_HandoverReference, 1),</span><br><span>   M_UINT       (PHO_RadioResources_t,  HandoverReference,  8),</span><br><span>@@ -4633,7 +4639,7 @@</span><br><span>   M_UNION      (Packet_Handover_Command_t, 4),</span><br><span>   M_TYPE       (Packet_Handover_Command_t, u.PS_HandoverTo_A_GB_ModePayload, PS_HandoverTo_A_GB_ModePayload_t),</span><br><span>   M_TYPE       (Packet_Handover_Command_t, u.PS_HandoverTo_UTRAN_Payload, PS_HandoverTo_UTRAN_Payload_t),</span><br><span style="color: hsl(0, 100%, 40%);">-  CSN_ERROR    (Packet_Handover_Command_t, "10 <extension> not implemented", CSN_ERROR_STREAM_NOT_SUPPORTED),</span><br><span style="color: hsl(120, 100%, 40%);">+  M_TYPE       (Packet_Handover_Command_t, u.PS_HandoverTo_E_UTRAN_Payload, PS_HandoverTo_E_UTRAN_Payload_t),</span><br><span>   CSN_ERROR    (Packet_Handover_Command_t, "11 <extension> not implemented", CSN_ERROR_STREAM_NOT_SUPPORTED),</span><br><span> </span><br><span>   M_PADDING_BITS(Packet_Handover_Command_t),</span><br><span>diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h</span><br><span>index 48abac0..e9ae20a 100644</span><br><span>--- a/src/gsm_rlcmac.h</span><br><span>+++ b/src/gsm_rlcmac.h</span><br><span>@@ -4877,6 +4877,11 @@</span><br><span>   guint8 RRC_Container[MAX_RRC_CONTAINER_LENGTH];</span><br><span> } PS_HandoverTo_UTRAN_Payload_t;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+typedef struct</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  guint8 RRC_ContainerLength;</span><br><span style="color: hsl(120, 100%, 40%);">+  guint8 RRC_Container[MAX_RRC_CONTAINER_LENGTH];</span><br><span style="color: hsl(120, 100%, 40%);">+} PS_HandoverTo_E_UTRAN_Payload_t;</span><br><span> </span><br><span> typedef struct</span><br><span> {</span><br><span>@@ -4929,6 +4934,7 @@</span><br><span>   {</span><br><span>     PS_HandoverTo_A_GB_ModePayload_t PS_HandoverTo_A_GB_ModePayload;</span><br><span>     PS_HandoverTo_UTRAN_Payload_t    PS_HandoverTo_UTRAN_Payload;</span><br><span style="color: hsl(120, 100%, 40%);">+    PS_HandoverTo_E_UTRAN_Payload_t  PS_HandoverTo_E_UTRAN_Payload;</span><br><span>   } u;</span><br><span> } Packet_Handover_Command_t;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17629">change 17629</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17629"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0f374e78300efddff00c4df26a401adcdee18a12 </div>
<div style="display:none"> Gerrit-Change-Number: 17629 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>