<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17606">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: use only LOGL_NOTICE as defualt loglevel<br><br>some of the log categories in logging.c are set to LOGL_INFO or even to<br>LOGL_DEBUG. This is too verbose. Lets set those categories to<br>LOGL_NOTICE. Also the BTS manager programs (...bts_mgr.c) use LOGL_INFO<br>by default. This should be set to LOGL_NOTICE as well<br><br>Related: OS#2577<br>Change-Id: I6e7a635f9b4a93529661dafc591d512d7b7e8c75<br>---<br>M src/common/logging.c<br>M src/osmo-bts-litecell15/misc/lc15bts_mgr.c<br>M src/osmo-bts-oc2g/misc/oc2gbts_mgr.c<br>M src/osmo-bts-sysmo/misc/sysmobts_mgr.c<br>4 files changed, 23 insertions(+), 23 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/17606/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/logging.c b/src/common/logging.c</span><br><span>index 8340736..5edb3ea 100644</span><br><span>--- a/src/common/logging.c</span><br><span>+++ b/src/common/logging.c</span><br><span>@@ -35,13 +35,13 @@</span><br><span> .name = "DRSL",</span><br><span> .description = "A-bis Radio Siganlling Link (RSL)",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DOML] = {</span><br><span> .name = "DOML",</span><br><span> .description = "A-bis Network Management / O&M (NM/OML)",</span><br><span> .color = "\033[1;36m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DRLL] = {</span><br><span> .name = "DRLL",</span><br><span>@@ -64,24 +64,24 @@</span><br><span> .name = "DPAG",</span><br><span> .description = "Paging Subsystem",</span><br><span> .color = "\033[1;38m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DL1C] = {</span><br><span> .name = "DL1C",</span><br><span> .description = "Layer 1 Control (MPH)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DL1P] = {</span><br><span> .name = "DL1P",</span><br><span> .description = "Layer 1 Primitives (PH)",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 0,</span><br><span> },</span><br><span> [DDSP] = {</span><br><span> .name = "DDSP",</span><br><span> .description = "DSP Trace Messages",</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> .enabled = 1,</span><br><span> },</span><br><span> [DABIS] = {</span><br><span>@@ -123,17 +123,17 @@</span><br><span> [DNS] = {</span><br><span> .name = "DNS",</span><br><span> .description = "GPRS Network Service (NS)",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DBSSGP] = {</span><br><span> .name = "DBSSGP",</span><br><span> .description = "GPRS BSS Gateway Protocol (BSSGP)",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DLLC] = {</span><br><span> .name = "DLLC",</span><br><span> .description = "GPRS Logical Link Control Protocol (LLC)",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> #endif</span><br><span> [DSUM] = {</span><br><span>diff --git a/src/osmo-bts-litecell15/misc/lc15bts_mgr.c b/src/osmo-bts-litecell15/misc/lc15bts_mgr.c</span><br><span>index ccacc1e..da21c9d 100644</span><br><span>--- a/src/osmo-bts-litecell15/misc/lc15bts_mgr.c</span><br><span>+++ b/src/osmo-bts-litecell15/misc/lc15bts_mgr.c</span><br><span>@@ -248,31 +248,31 @@</span><br><span> .name = "DTEMP",</span><br><span> .description = "Temperature monitoring",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DFW] = {</span><br><span> .name = "DFW",</span><br><span> .description = "Firmware management",</span><br><span> .color = "\033[1;36m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DFIND] = {</span><br><span> .name = "DFIND",</span><br><span> .description = "ipaccess-find handling",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DCALIB] = {</span><br><span> .name = "DCALIB",</span><br><span> .description = "Calibration handling",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DSWD] = {</span><br><span> .name = "DSWD",</span><br><span> .description = "Software Watchdog",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c</span><br><span>index 25948b0..66c9f28 100644</span><br><span>--- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c</span><br><span>+++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr.c</span><br><span>@@ -228,31 +228,31 @@</span><br><span> .name = "DTEMP",</span><br><span> .description = "Temperature monitoring",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DFW] = {</span><br><span> .name = "DFW",</span><br><span> .description = "Firmware management",</span><br><span> .color = "\033[1;36m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DFIND] = {</span><br><span> .name = "DFIND",</span><br><span> .description = "ipaccess-find handling",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DCALIB] = {</span><br><span> .name = "DCALIB",</span><br><span> .description = "Calibration handling",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DSWD] = {</span><br><span> .name = "DSWD",</span><br><span> .description = "Software Watchdog",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr.c b/src/osmo-bts-sysmo/misc/sysmobts_mgr.c</span><br><span>index 50c9c22..dc7af3c 100644</span><br><span>--- a/src/osmo-bts-sysmo/misc/sysmobts_mgr.c</span><br><span>+++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr.c</span><br><span>@@ -218,25 +218,25 @@</span><br><span> .name = "DTEMP",</span><br><span> .description = "Temperature monitoring",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DFW] = {</span><br><span> .name = "DFW",</span><br><span> .description = "DSP/FPGA firmware management",</span><br><span> .color = "\033[1;36m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DFIND] = {</span><br><span> .name = "DFIND",</span><br><span> .description = "ipaccess-find handling",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DCALIB] = {</span><br><span> .name = "DCALIB",</span><br><span> .description = "Calibration handling",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/17606">change 17606</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/17606"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6e7a635f9b4a93529661dafc591d512d7b7e8c75 </div>
<div style="display:none"> Gerrit-Change-Number: 17606 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>