<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17567">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx: Use NOPE indications on SDCCH<br><br>Without using the NOPE indication it might happen that we get<br>into the following situation:<br>* bursts 0,1,2 of a given block are received<br>* burst 3 is lost on the radio interface, OsmoTRX sends NOPE<br>* osmo-bts-trx doesn't pass the NOPE the the rx_tch*_fn()<br>* we never detect the end of the block, never perform decoding<br> and even if the burst could be fully decoded, we loose the block<br><br>Related: OS#4661<br>Related: OS#2975<br>Change-Id: Idfc5c9a23db808c5f87ef5646c7e1d1cd3127371<br>---<br>M src/common/scheduler.c<br>1 file changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index 054b6ca..652582b 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -236,6 +236,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH4_1] = {</span><br><span> .name = "SDCCH/4(1)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -247,6 +248,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH4_2] = {</span><br><span> .name = "SDCCH/4(2)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -258,6 +260,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH4_3] = {</span><br><span> .name = "SDCCH/4(3)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -269,6 +272,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_0] = {</span><br><span> .name = "SDCCH/8(0)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -280,6 +284,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_1] = {</span><br><span> .name = "SDCCH/8(1)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -291,6 +296,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_2] = {</span><br><span> .name = "SDCCH/8(2)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -302,6 +308,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_3] = {</span><br><span> .name = "SDCCH/8(3)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -313,6 +320,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_4] = {</span><br><span> .name = "SDCCH/8(4)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -324,6 +332,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_5] = {</span><br><span> .name = "SDCCH/8(5)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -335,6 +344,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_6] = {</span><br><span> .name = "SDCCH/8(6)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -346,6 +356,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SDCCH8_7] = {</span><br><span> .name = "SDCCH/8(7)", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span>@@ -357,6 +368,7 @@</span><br><span> .rts_fn = rts_data_fn,</span><br><span> .dl_fn = tx_data_fn,</span><br><span> .ul_fn = rx_data_fn,</span><br><span style="color: hsl(120, 100%, 40%);">+ .nope_fn = rx_data_fn,</span><br><span> },</span><br><span> [TRXC_SACCHTF] = {</span><br><span> .name = "SACCH/TF", /* 3GPP TS 05.02, section 3.3.4.1 */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/17567">change 17567</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/17567"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idfc5c9a23db808c5f87ef5646c7e1d1cd3127371 </div>
<div style="display:none"> Gerrit-Change-Number: 17567 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>