<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17551">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-sim-test: Use stderr for error messages<br><br>Change-Id: I8f36b07b8601af2b0d54d95c3c6374d6c54bafd1<br>---<br>M utils/osmo-sim-test.c<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/17551/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c</span><br><span>index 27de0bc..2bf83fa 100644</span><br><span>--- a/utils/osmo-sim-test.c</span><br><span>+++ b/utils/osmo-sim-test.c</span><br><span>@@ -326,25 +326,25 @@</span><br><span> </span><br><span>    msg = select_file(chan, fid);</span><br><span>        if (!msg) {</span><br><span style="color: hsl(0, 100%, 40%);">-             printf("Unable to select file\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          fprintf(stderr, "Unable to select file\n");</span><br><span>                return -EIO;</span><br><span>         }</span><br><span>    printf("SW: %s\n", osim_print_sw(chan->card, msgb_apdu_sw(msg)));</span><br><span>       if (msgb_apdu_sw(msg) != 0x9000) {</span><br><span style="color: hsl(0, 100%, 40%);">-              printf("status 0x%04x selecting file\n", msgb_apdu_sw(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+                fprintf(stderr, "status 0x%04x selecting file\n", msgb_apdu_sw(msg));</span><br><span>              goto out;</span><br><span>    }</span><br><span> </span><br><span>        if (g_class != 0xA0) {</span><br><span>               rc = tlv_parse(&tp, &ts102221_fcp_tlv_def, msgb_apdu_de(msg)+2, msgb_apdu_le(msg)-2, 0, 0);</span><br><span>          if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        printf("Unable to parse FCP: %s\n", msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+                     fprintf(stderr, "Unable to parse FCP: %s\n", msgb_hexdump(msg));</span><br><span>                   goto out;</span><br><span>            }</span><br><span> </span><br><span>                if (!TLVP_PRESENT(&tp, UICC_FCP_T_FILE_DESC) ||</span><br><span>              TLVP_LEN(&tp, UICC_FCP_T_FILE_DESC) < 2) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   printf("No file descriptor present ?!?\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                 fprintf(stderr, "No file descriptor present ?!?\n");</span><br><span>                       goto out;</span><br><span>            }</span><br><span> </span><br><span>@@ -355,12 +355,12 @@</span><br><span>        }</span><br><span> </span><br><span>        if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                printf("Unable to decode File Descriptor\n");</span><br><span style="color: hsl(120, 100%, 40%);">+               fprintf(stderr, "Unable to decode File Descriptor\n");</span><br><span>             goto out;</span><br><span>    }</span><br><span> </span><br><span>        if (ffdd.type != TYPE_EF) {</span><br><span style="color: hsl(0, 100%, 40%);">-             printf("File Type != EF\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                fprintf(stderr, "File Type != EF\n");</span><br><span>              goto out;</span><br><span>    }</span><br><span> </span><br><span>@@ -384,7 +384,7 @@</span><br><span>                  i = ntohs(*(uint16_t *)TLVP_VAL(&tp, UICC_FCP_T_FILE_SIZE));</span><br><span>                     printf("File size: %d bytes\n", i);</span><br><span>                } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                        printf("Can not determine file size, invalid EF-type!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                  fprintf(stderr, "Can not determine file size, invalid EF-type!\n");</span><br><span>                        goto out;</span><br><span>            }</span><br><span>            for (offset = 0; offset < i-1; ) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/17551">change 17551</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/17551"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8f36b07b8601af2b0d54d95c3c6374d6c54bafd1 </div>
<div style="display:none"> Gerrit-Change-Number: 17551 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>