<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-iuh/+/17545">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix compiler warning on signedness of char ptr using OCTET_STRING_fromBuf()<br><br>rua_msg_factory.c:19:48: warning: pointer targets in passing argument 2 of ‘OCTET_STRING_fromBuf’ differ in signedness [-Wpointer-sign]<br><br>Change-Id: Ie0a2e8e11902dc56720ff8121edde0e148fa587a<br>---<br>M src/hnbgw_hnbap.c<br>M src/rua_msg_factory.c<br>2 files changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c</span><br><span>index 2d67219..c118774 100644</span><br><span>--- a/src/hnbgw_hnbap.c</span><br><span>+++ b/src/hnbgw_hnbap.c</span><br><span>@@ -194,10 +194,10 @@</span><br><span> ue_id->choice.tMSILAI.tMSI.size * 8</span><br><span> - ue_id->choice.tMSILAI.tMSI.bits_unused);</span><br><span> OCTET_STRING_fromBuf(&reject.uE_Identity.choice.tMSILAI.lAI.pLMNID,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.tMSILAI.lAI.pLMNID.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.tMSILAI.lAI.pLMNID.buf,</span><br><span> ue_id->choice.tMSILAI.lAI.pLMNID.size);</span><br><span> OCTET_STRING_fromBuf(&reject.uE_Identity.choice.tMSILAI.lAI.lAC,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.tMSILAI.lAI.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.tMSILAI.lAI.lAC.buf,</span><br><span> ue_id->choice.tMSILAI.lAI.lAC.size);</span><br><span> break;</span><br><span> </span><br><span>@@ -227,13 +227,13 @@</span><br><span> ue_id->choice.pTMSIRAI.pTMSI.size * 8</span><br><span> - ue_id->choice.pTMSIRAI.pTMSI.bits_unused);</span><br><span> OCTET_STRING_fromBuf(&reject.uE_Identity.choice.pTMSIRAI.rAI.lAI.pLMNID,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.pTMSIRAI.rAI.lAI.pLMNID.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.pTMSIRAI.rAI.lAI.pLMNID.buf,</span><br><span> ue_id->choice.pTMSIRAI.rAI.lAI.pLMNID.size);</span><br><span> OCTET_STRING_fromBuf(&reject.uE_Identity.choice.pTMSIRAI.rAI.lAI.lAC,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.pTMSIRAI.rAI.lAI.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.pTMSIRAI.rAI.lAI.lAC.buf,</span><br><span> ue_id->choice.pTMSIRAI.rAI.lAI.lAC.size);</span><br><span> OCTET_STRING_fromBuf(&reject.uE_Identity.choice.pTMSIRAI.rAI.rAC,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.pTMSIRAI.rAI.rAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.pTMSIRAI.rAI.rAC.buf,</span><br><span> ue_id->choice.pTMSIRAI.rAI.rAC.size);</span><br><span> break;</span><br><span> </span><br><span>@@ -312,10 +312,10 @@</span><br><span> - ue_id->choice.tMSILAI.tMSI.bits_unused);</span><br><span> tmsi = *(uint32_t*)accept.uE_Identity.choice.tMSILAI.tMSI.buf;</span><br><span> OCTET_STRING_fromBuf(&accept.uE_Identity.choice.tMSILAI.lAI.pLMNID,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.tMSILAI.lAI.pLMNID.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.tMSILAI.lAI.pLMNID.buf,</span><br><span> ue_id->choice.tMSILAI.lAI.pLMNID.size);</span><br><span> OCTET_STRING_fromBuf(&accept.uE_Identity.choice.tMSILAI.lAI.lAC,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.tMSILAI.lAI.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.tMSILAI.lAI.lAC.buf,</span><br><span> ue_id->choice.tMSILAI.lAI.lAC.size);</span><br><span> break;</span><br><span> </span><br><span>@@ -326,13 +326,13 @@</span><br><span> - ue_id->choice.pTMSIRAI.pTMSI.bits_unused);</span><br><span> tmsi = *(uint32_t*)accept.uE_Identity.choice.pTMSIRAI.pTMSI.buf;</span><br><span> OCTET_STRING_fromBuf(&accept.uE_Identity.choice.pTMSIRAI.rAI.lAI.pLMNID,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.pTMSIRAI.rAI.lAI.pLMNID.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.pTMSIRAI.rAI.lAI.pLMNID.buf,</span><br><span> ue_id->choice.pTMSIRAI.rAI.lAI.pLMNID.size);</span><br><span> OCTET_STRING_fromBuf(&accept.uE_Identity.choice.pTMSIRAI.rAI.lAI.lAC,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.pTMSIRAI.rAI.lAI.lAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.pTMSIRAI.rAI.lAI.lAC.buf,</span><br><span> ue_id->choice.pTMSIRAI.rAI.lAI.lAC.size);</span><br><span> OCTET_STRING_fromBuf(&accept.uE_Identity.choice.pTMSIRAI.rAI.rAC,</span><br><span style="color: hsl(0, 100%, 40%);">- ue_id->choice.pTMSIRAI.rAI.rAC.buf,</span><br><span style="color: hsl(120, 100%, 40%);">+ (const char *)ue_id->choice.pTMSIRAI.rAI.rAC.buf,</span><br><span> ue_id->choice.pTMSIRAI.rAI.rAC.size);</span><br><span> break;</span><br><span> </span><br><span>diff --git a/src/rua_msg_factory.c b/src/rua_msg_factory.c</span><br><span>index 268f6ac..7a6bebd 100644</span><br><span>--- a/src/rua_msg_factory.c</span><br><span>+++ b/src/rua_msg_factory.c</span><br><span>@@ -16,7 +16,7 @@</span><br><span> int rc;</span><br><span> </span><br><span> memset(&ies, 0, sizeof(ies));</span><br><span style="color: hsl(0, 100%, 40%);">- OCTET_STRING_fromBuf(&ies.ranaP_Message, inmsg->data, msgb_length(inmsg));</span><br><span style="color: hsl(120, 100%, 40%);">+ OCTET_STRING_fromBuf(&ies.ranaP_Message, (const char *)inmsg->data, msgb_length(inmsg));</span><br><span> msgb_free(inmsg);</span><br><span> </span><br><span> memset(&out, 0, sizeof(out));</span><br><span>@@ -53,7 +53,7 @@</span><br><span> ies.cN_DomainIndicator = RUA_CN_DomainIndicator_cs_domain;</span><br><span> asn1_u24_to_bitstring(&ies.context_ID, &ctxidbuf, context_id);</span><br><span> ies.establishment_Cause = RUA_Establishment_Cause_normal_call;</span><br><span style="color: hsl(0, 100%, 40%);">- OCTET_STRING_fromBuf(&ies.ranaP_Message, inmsg->data, msgb_length(inmsg));</span><br><span style="color: hsl(120, 100%, 40%);">+ OCTET_STRING_fromBuf(&ies.ranaP_Message, (const char *)inmsg->data, msgb_length(inmsg));</span><br><span> msgb_free(inmsg);</span><br><span> </span><br><span> memset(&out, 0, sizeof(out));</span><br><span>@@ -89,7 +89,7 @@</span><br><span> else</span><br><span> ies.cN_DomainIndicator = RUA_CN_DomainIndicator_cs_domain;</span><br><span> asn1_u24_to_bitstring(&ies.context_ID, &ctxidbuf, context_id);</span><br><span style="color: hsl(0, 100%, 40%);">- OCTET_STRING_fromBuf(&ies.ranaP_Message, inmsg->data, msgb_length(inmsg));</span><br><span style="color: hsl(120, 100%, 40%);">+ OCTET_STRING_fromBuf(&ies.ranaP_Message, (const char *)inmsg->data, msgb_length(inmsg));</span><br><span> msgb_free(inmsg);</span><br><span> </span><br><span> memset(&out, 0, sizeof(out));</span><br><span>@@ -130,7 +130,7 @@</span><br><span> ies.cause.choice.radioNetwork = RUA_CauseRadioNetwork_normal;</span><br><span> if (inmsg && inmsg->data&& msgb_length(inmsg)) {</span><br><span> ies.presenceMask |= DISCONNECTIES_RUA_RANAP_MESSAGE_PRESENT;</span><br><span style="color: hsl(0, 100%, 40%);">- OCTET_STRING_fromBuf(&ies.ranaP_Message, inmsg->data, msgb_length(inmsg));</span><br><span style="color: hsl(120, 100%, 40%);">+ OCTET_STRING_fromBuf(&ies.ranaP_Message, (const char *)inmsg->data, msgb_length(inmsg));</span><br><span> }</span><br><span> msgb_free(inmsg);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-iuh/+/17545">change 17545</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-iuh/+/17545"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie0a2e8e11902dc56720ff8121edde0e148fa587a </div>
<div style="display:none"> Gerrit-Change-Number: 17545 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>