<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17530">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1.c: Almost all of the logging is DEBUG, not NOTICE<br><br>low-level text decodes of CSN.1 messages certainly are not NOTICEable<br>events, but rather something used for debugging.<br><br>Right now we get various text CSN.1 log output of osmo-pcu in it's<br>default configuration. Despite all log levels being relatively high<br>(NOTICE), we still see those messages as they simply are logged<br>at the wrong level.<br><br>Related: OS#2577<br>Change-Id: I7b42c9e21ad8d8a5b54e7a3b68490934ce3d3198<br>---<br>M src/csn1.c<br>M tests/rlcmac/RLCMACTest.cpp<br>2 files changed, 107 insertions(+), 107 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/17530/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.c b/src/csn1.c</span><br><span>index 6fab9a9..296bf6c 100644</span><br><span>--- a/src/csn1.c</span><br><span>+++ b/src/csn1.c</span><br><span>@@ -168,14 +168,14 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> /* end add the bit value to protocol tree */</span><br><span> }</span><br><span> else if(pDescr->may_be_null)</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = NULL | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -206,21 +206,21 @@</span><br><span> guint8 ui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = ui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> guint16 ui16 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> *pui16 = ui16;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> guint32 ui32 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> *pui32 = ui32;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = 0x%08x | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = 0x%08x | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -246,7 +246,7 @@</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> *pui32 = 0;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = NULL | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -268,21 +268,21 @@</span><br><span> guint8 ui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = ui8 + (guint8)pDescr->descr.value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> guint16 ui16 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> *pui16 = ui16 + (guint16)pDescr->descr.value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> guint32 ui32 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> *pui32 = ui32 + (guint16)pDescr->descr.value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -311,7 +311,7 @@</span><br><span> guint8 ui8 = get_masked_bits8(vector, readIndex, bit_offset, no_of_bits);</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = ui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else</span><br><span> {/* Maybe we should support more than 8 bits ? */</span><br><span>@@ -348,7 +348,7 @@</span><br><span> do</span><br><span> {</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> bit_offset += no_of_bits;</span><br><span> } while (--nCount > 0);</span><br><span>@@ -399,7 +399,7 @@</span><br><span> * but no bits shall be read from bitstream</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamDecoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, readIndex, pui8);</span><br><span> if (Status >= 0)</span><br><span>@@ -433,7 +433,7 @@</span><br><span> guint8 ui8 = bitvec_read_field(vector, readIndex, 8);</span><br><span> pui8 = pui8DATA(data, pDescr->offset+ib);</span><br><span> *pui8 = ui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span> }</span><br><span> }</span><br><span> else if (no_of_bits <= 64)</span><br><span>@@ -443,7 +443,7 @@</span><br><span> guint8 ui8 = bitvec_read_field(vector, readIndex, 8);</span><br><span> pui8 = pui8DATA(data, pDescr->offset+ib);</span><br><span> *pui8 = ui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span> }</span><br><span> }</span><br><span> else</span><br><span>@@ -465,10 +465,10 @@</span><br><span> {</span><br><span> gint16 Status;</span><br><span> csnStream_t arT = *ar;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : %s | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamDecoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, readIndex, pvDATA(data, pDescr->offset));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, ": End %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, ": End %s | ", pDescr->sz);</span><br><span> if (Status >= 0)</span><br><span> {</span><br><span> remaining_bits_len = arT.remaining_bits_len;</span><br><span>@@ -509,7 +509,7 @@</span><br><span> descr[1].type = CSN_END;</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = i;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "Choice %s = %u | ", pDescr->sz , (unsigned)value);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "Choice %s = %u | ", pDescr->sz , (unsigned)value);</span><br><span> if (!pChoice->keep_bits) {</span><br><span> bit_offset += no_of_bits;</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span>@@ -553,13 +553,13 @@</span><br><span> </span><br><span> guint8 length = bitvec_read_field(vector, readIndex, length_len);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s length = %u | ", pDescr->sz , length);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s length = %u | ", pDescr->sz , length);</span><br><span> bit_offset += length_len;</span><br><span> remaining_bits_len -= length_len;</span><br><span> </span><br><span> csnStreamInit(&arT, bit_offset, length > 0 ? length : remaining_bits_len);</span><br><span> arT.direction = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "offset = %u | ", pDescr->offset);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "offset = %u | ", pDescr->offset);</span><br><span> Status = serialize(&arT, vector, readIndex, pvDATA(data, pDescr->offset));</span><br><span> </span><br><span> if (Status >= 0)</span><br><span>@@ -574,7 +574,7 @@</span><br><span> </span><br><span> /* Skip bits not handled by serialize(), if any */</span><br><span> if (Status > 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "skipped = %d | ", Status);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "skipped = %d | ", Status);</span><br><span> *readIndex += Status;</span><br><span> }</span><br><span> </span><br><span>@@ -631,7 +631,7 @@</span><br><span> </span><br><span> /* script index to continue on, limited in case we do not have a power of 2 */</span><br><span> pDescr += (MIN(index + 1, count));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> </span><br><span> switch (pDescr->type)</span><br><span> { /* get the right element of the union based on computed index */</span><br><span>@@ -644,7 +644,7 @@</span><br><span> {</span><br><span> *pui8 = 0x01;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> remaining_bits_len -= 1;</span><br><span> bit_offset++;</span><br><span> pDescr++;</span><br><span>@@ -668,21 +668,21 @@</span><br><span> guint8 ui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = ui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> guint16 ui16 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> *pui16 = ui16;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> guint32 ui32 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> *pui32 = ui32;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -711,21 +711,21 @@</span><br><span> guint8 ui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = ui8 + (guint8)pDescr->descr.value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> guint16 ui16 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> *pui16 = ui16 + (guint16)pDescr->descr.value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> guint32 ui32 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> *pui32 = ui32 + (guint16)pDescr->descr.value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -754,7 +754,7 @@</span><br><span> guint8 ui8 = get_masked_bits8(vector, readIndex, bit_offset, no_of_bits);</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> *pui8 = ui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else</span><br><span> { /* Maybe we should support more than 8 bits ? */</span><br><span>@@ -792,7 +792,7 @@</span><br><span> while (nCount > 0)</span><br><span> {</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> bit_offset += no_of_bits;</span><br><span> nCount--;</span><br><span>@@ -805,7 +805,7 @@</span><br><span> while (nCount > 0)</span><br><span> {</span><br><span> *pui16 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> pui16++;</span><br><span> bit_offset += no_of_bits;</span><br><span> nCount--;</span><br><span>@@ -852,7 +852,7 @@</span><br><span> </span><br><span> while (nCount--) /* Changed to handle length = 0. */</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamDecoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, readIndex, pui8);</span><br><span> if (Status >= 0)</span><br><span>@@ -889,7 +889,7 @@</span><br><span> guint64 ui64 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span> pui64 = pui64DATA(data, pDescr->offset);</span><br><span> *pui64 = ui64;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %lu | ", pDescr->sz , *pui64);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %lu | ", pDescr->sz , *pui64);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -910,10 +910,10 @@</span><br><span> {</span><br><span> gint16 Status;</span><br><span> csnStream_t arT = *ar;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : %s | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamDecoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, readIndex, pvDATA(data, pDescr->offset));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : End %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : End %s | ", pDescr->sz);</span><br><span> if (Status >= 0)</span><br><span> {</span><br><span> remaining_bits_len = arT.remaining_bits_len;</span><br><span>@@ -955,7 +955,7 @@</span><br><span> }</span><br><span> </span><br><span> *pui8 = fExist;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pDescr++;</span><br><span> bit_offset++;</span><br><span> remaining_bits_len -= 1;</span><br><span>@@ -998,7 +998,7 @@</span><br><span> </span><br><span> *pui8 = fExist;</span><br><span> remaining_bits_len -= 1;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> ++bit_offset;</span><br><span> </span><br><span> if (fExist == 0)</span><br><span>@@ -1035,7 +1035,7 @@</span><br><span> </span><br><span> /* the "regular" M_NEXT_EXIST_LH description element */</span><br><span> fExist = get_masked_bits8(vector, readIndex, bit_offset, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)fExist);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)fExist);</span><br><span> *pui8++ = fExist;</span><br><span> remaining_bits_len -= 1;</span><br><span> </span><br><span>@@ -1085,7 +1085,7 @@</span><br><span> if (nB1 > 0)</span><br><span> { /* take care of the first byte - it will be right aligned */</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, nB1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= nB1;</span><br><span> bit_offset += nB1; /* (nB1 is no_of_bits Mod 8) */</span><br><span>@@ -1095,7 +1095,7 @@</span><br><span> while (no_of_bits > 0)</span><br><span> {</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= 8;</span><br><span> }</span><br><span>@@ -1139,14 +1139,14 @@</span><br><span> while (no_of_bits >= 8)</span><br><span> {</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= 8;</span><br><span> }</span><br><span> if (no_of_bits > 0)</span><br><span> { </span><br><span> *pui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> bit_offset += no_of_bits;</span><br><span> no_of_bits = 0;</span><br><span>@@ -1161,7 +1161,7 @@</span><br><span> </span><br><span> case CSN_PADDING_BITS:</span><br><span> { /* Padding from here and to the end of message */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = ", pDescr->sz);</span><br><span> if (remaining_bits_len > 0)</span><br><span> {</span><br><span> while (remaining_bits_len > 0)</span><br><span>@@ -1169,13 +1169,13 @@</span><br><span> guint bits_to_handle = remaining_bits_len%8;</span><br><span> if (bits_to_handle > 0)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%d|", bitvec_get_uint(vector, bits_to_handle));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%d|", bitvec_get_uint(vector, bits_to_handle));</span><br><span> remaining_bits_len -= bits_to_handle;</span><br><span> bit_offset += bits_to_handle;</span><br><span> }</span><br><span> else if (bits_to_handle == 0)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%d|", bitvec_get_uint(vector, 8));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%d|", bitvec_get_uint(vector, 8));</span><br><span> remaining_bits_len -= 8;</span><br><span> bit_offset += 8;</span><br><span> }</span><br><span>@@ -1217,7 +1217,7 @@</span><br><span> {</span><br><span> readIndex -= 8;</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> bit_offset += 8;</span><br><span> count--;</span><br><span>@@ -1244,13 +1244,13 @@</span><br><span> </span><br><span> while (existNextElement(vector, readIndex, Tag))</span><br><span> { /* tag control shows existence of next list elements */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = Exist | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = Exist | ", pDescr->sz);</span><br><span> bit_offset++;</span><br><span> remaining_bits_len--;</span><br><span> </span><br><span> /* extract and store no_of_bits long element from bitstream */</span><br><span> *pui8 = bitvec_read_field(vector, readIndex, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> ElementCount++;</span><br><span>@@ -1263,7 +1263,7 @@</span><br><span> bit_offset += no_of_bits;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %d | ", pDescr->sz , bitvec_get_uint(vector, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %d | ", pDescr->sz , bitvec_get_uint(vector, 1));</span><br><span> /* existNextElement() returned FALSE, 1 bit consumed */</span><br><span> bit_offset++;</span><br><span> remaining_bits_len--;</span><br><span>@@ -1286,7 +1286,7 @@</span><br><span> </span><br><span> while (existNextElement(vector, readIndex, Tag))</span><br><span> { /* tag control shows existence of next list elements */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = Exist | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = Exist | ", pDescr->sz);</span><br><span> /* existNextElement() returned TRUE, 1 bit consumed */</span><br><span> bit_offset++;</span><br><span> remaining_bits_len--;</span><br><span>@@ -1316,7 +1316,7 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %d | ", pDescr->sz , bitvec_get_uint(vector, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %d | ", pDescr->sz , bitvec_get_uint(vector, 1));</span><br><span> </span><br><span> /* existNextElement() returned FALSE, 1 bit consumed */</span><br><span> remaining_bits_len--;</span><br><span>@@ -1355,7 +1355,7 @@</span><br><span> { /* get data element */</span><br><span> ElementCount++;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s { | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s { | ", pDescr->sz);</span><br><span> </span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamDecoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, readIndex, pui8);</span><br><span>@@ -1377,7 +1377,7 @@</span><br><span> }</span><br><span> </span><br><span> /* control of next element's tag */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s } | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s } | ", pDescr->sz);</span><br><span> EndOfList = !(existNextElement(vector, readIndex, Tag));</span><br><span> </span><br><span> bit_offset++;</span><br><span>@@ -1410,7 +1410,7 @@</span><br><span> return ProcessError(readIndex,"csnStreamDecoder FIXED value does not match", -1, pDescr);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned int)ui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned int)ui32);</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> bit_offset += no_of_bits;</span><br><span> pDescr++;</span><br><span>@@ -1478,12 +1478,12 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> /* end add the bit value to protocol tree */</span><br><span> }</span><br><span> else if(pDescr->may_be_null)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = NULL | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -1512,19 +1512,19 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui16, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui32, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -1536,7 +1536,7 @@</span><br><span> }</span><br><span> else if(pDescr->may_be_null)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = NULL | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = NULL | ", pDescr->sz);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -1557,19 +1557,19 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8 - (guint8)pDescr->descr.value, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)(*pui8 - (guint8)pDescr->descr.value));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)(*pui8 - (guint8)pDescr->descr.value));</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui16 - (guint16)pDescr->descr.value, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned short)(*pui16 - (guint16)pDescr->descr.value));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned short)(*pui16 - (guint16)pDescr->descr.value));</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui32 - (guint16)pDescr->descr.value, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned int)(*pui32 - (guint16)pDescr->descr.value));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned int)(*pui32 - (guint16)pDescr->descr.value));</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -1602,7 +1602,7 @@</span><br><span> guint8 ui8 = get_masked_bits8(vector, writeIndex, bit_offset, no_of_bits);</span><br><span> *writeIndex -= no_of_bits;</span><br><span> bitvec_write_field(vector, writeIndex, ui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> </span><br><span> }</span><br><span> else</span><br><span>@@ -1639,7 +1639,7 @@</span><br><span> do</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> bit_offset += no_of_bits;</span><br><span>@@ -1691,7 +1691,7 @@</span><br><span> * but no bits shall be read from bitstream</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s : | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s : | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamEncoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, writeIndex, pui8);</span><br><span> if (Status >= 0)</span><br><span>@@ -1725,7 +1725,7 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset+ib);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span> }</span><br><span> }</span><br><span> else if (no_of_bits <= 64)</span><br><span>@@ -1734,7 +1734,7 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset+ib);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s[%u] = %u | ", pDescr->sz , ib, (unsigned)*pui8);</span><br><span> }</span><br><span> }</span><br><span> else</span><br><span>@@ -1756,10 +1756,10 @@</span><br><span> {</span><br><span> gint16 Status;</span><br><span> csnStream_t arT = *ar;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : %s | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamEncoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, writeIndex, pvDATA(data, pDescr->offset));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : End %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : End %s | ", pDescr->sz);</span><br><span> if (Status >= 0)</span><br><span> {</span><br><span> </span><br><span>@@ -1787,7 +1787,7 @@</span><br><span> pChoice += i;</span><br><span> guint8 no_of_bits = pChoice->bits;</span><br><span> guint8 value = pChoice->value;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pChoice->descr.sz , (unsigned)value);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pChoice->descr.sz , (unsigned)value);</span><br><span> bitvec_write_field(vector, writeIndex, value, no_of_bits);</span><br><span> </span><br><span> CSN_DESCR descr[2];</span><br><span>@@ -1835,7 +1835,7 @@</span><br><span> Status = serialize(&arT, vector, writeIndex, pvDATA(data, pDescr->offset));</span><br><span> </span><br><span> bitvec_write_field(vector, &lengthIndex, *writeIndex - lengthIndex - length_len, length_len);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s length = %u | ", pDescr->sz , (unsigned)(*writeIndex - lengthIndex));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s length = %u | ", pDescr->sz , (unsigned)(*writeIndex - lengthIndex));</span><br><span> </span><br><span> if (Status >= 0)</span><br><span> {</span><br><span>@@ -1902,7 +1902,7 @@</span><br><span> </span><br><span> /* script index to continue on, limited in case we do not have a power of 2 */</span><br><span> pDescr += (MIN(index + 1, count));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)index);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)index);</span><br><span> </span><br><span> switch (pDescr->type)</span><br><span> { /* get the right element of the union based on computed index */</span><br><span>@@ -1911,7 +1911,7 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> remaining_bits_len--;</span><br><span> bit_offset++;</span><br><span> pDescr++;</span><br><span>@@ -1933,19 +1933,19 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui16, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui16);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui16);</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui32, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -1973,19 +1973,19 @@</span><br><span> {</span><br><span> pui8 = pui8DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui8 - (guint8)pDescr->descr.value, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)(*pui8 - (guint8)pDescr->descr.value));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)(*pui8 - (guint8)pDescr->descr.value));</span><br><span> }</span><br><span> else if (no_of_bits <= 16)</span><br><span> {</span><br><span> pui16 = pui16DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui16 - (guint16)pDescr->descr.value, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned short)(*pui16 - (guint16)pDescr->descr.value));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned short)(*pui16 - (guint16)pDescr->descr.value));</span><br><span> }</span><br><span> else if (no_of_bits <= 32)</span><br><span> {</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui32 - (guint16)pDescr->descr.value, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned int)(*pui32 - (guint16)pDescr->descr.value));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned int)(*pui32 - (guint16)pDescr->descr.value));</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -2019,7 +2019,7 @@</span><br><span> guint8 ui8 = get_masked_bits8(vector, writeIndex, bit_offset, no_of_bits);</span><br><span> *writeIndex -= no_of_bits;</span><br><span> bitvec_write_field(vector, writeIndex, ui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> </span><br><span> }</span><br><span> else</span><br><span>@@ -2056,7 +2056,7 @@</span><br><span> do</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> bit_offset += no_of_bits;</span><br><span>@@ -2108,7 +2108,7 @@</span><br><span> * but no bits shall be read from bitstream</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s : | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s : | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamEncoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, writeIndex, pui8);</span><br><span> if (Status >= 0)</span><br><span>@@ -2139,13 +2139,13 @@</span><br><span> {</span><br><span> pui32 = pui32DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui32, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , *pui32);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , *pui32);</span><br><span> }</span><br><span> else if (no_of_bits <= 64)</span><br><span> {</span><br><span> pui64 = pui64DATA(data, pDescr->offset);</span><br><span> bitvec_write_field(vector, writeIndex, *pui64, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %lu | ", pDescr->sz , *pui64);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %lu | ", pDescr->sz , *pui64);</span><br><span> }</span><br><span> else</span><br><span> {</span><br><span>@@ -2166,10 +2166,10 @@</span><br><span> {</span><br><span> gint16 Status;</span><br><span> csnStream_t arT = *ar;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : %s | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamEncoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, writeIndex, pvDATA(data, pDescr->offset));</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, " : End %s | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, " : End %s | ", pDescr->sz);</span><br><span> if (Status >= 0)</span><br><span> {</span><br><span> remaining_bits_len = arT.remaining_bits_len;</span><br><span>@@ -2214,7 +2214,7 @@</span><br><span> }</span><br><span> writeIndex--;</span><br><span> bitvec_write_field(vector, writeIndex, fExist, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz, (unsigned)fExist);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz, (unsigned)fExist);</span><br><span> remaining_bits_len--;</span><br><span> bit_offset++;</span><br><span> pDescr++;</span><br><span>@@ -2246,7 +2246,7 @@</span><br><span> </span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 1);</span><br><span> fExist = *pui8;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> </span><br><span> remaining_bits_len--;</span><br><span> bit_offset++;</span><br><span>@@ -2331,7 +2331,7 @@</span><br><span> if (nB1 > 0)</span><br><span> { /* take care of the first byte - it will be right aligned */</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, nB1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= nB1;</span><br><span> bit_offset += nB1; /* (nB1 is no_of_bits Mod 8) */</span><br><span>@@ -2342,7 +2342,7 @@</span><br><span> while (no_of_bits > 0)</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= 8;</span><br><span> remaining_bits_len -= 8;</span><br><span>@@ -2389,14 +2389,14 @@</span><br><span> while (no_of_bits > 0)</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= 8;</span><br><span> }</span><br><span> if (nB1 > 0)</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, nB1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> no_of_bits -= nB1;</span><br><span> bit_offset += nB1; /* (nB1 is no_of_bits Mod 8) */</span><br><span>@@ -2412,7 +2412,7 @@</span><br><span> </span><br><span> case CSN_PADDING_BITS:</span><br><span> { /* Padding from here and to the end of message */</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = ", pDescr->sz);</span><br><span> guint8 filler = 0x2b;</span><br><span> if (remaining_bits_len > 0)</span><br><span> {</span><br><span>@@ -2428,14 +2428,14 @@</span><br><span> */</span><br><span> guint8 fl = filler&(0xff>>(8-bits_to_handle + 1));</span><br><span> bitvec_write_field(vector, writeIndex, fl, bits_to_handle);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%u|", fl);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%u|", fl);</span><br><span> remaining_bits_len -= bits_to_handle;</span><br><span> bit_offset += bits_to_handle;</span><br><span> }</span><br><span> else if (bits_to_handle == 0)</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, filler, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%u|", filler);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%u|", filler);</span><br><span> remaining_bits_len -= 8;</span><br><span> bit_offset += 8;</span><br><span> }</span><br><span>@@ -2474,7 +2474,7 @@</span><br><span> while (count > 0)</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, 8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> bit_offset += 8;</span><br><span> remaining_bits_len -= 8;</span><br><span>@@ -2502,13 +2502,13 @@</span><br><span> while (ElementCount > 0)</span><br><span> { /* tag control shows existence of next list elements */</span><br><span> bitvec_write_field(vector, writeIndex, Tag, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)Tag);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)Tag);</span><br><span> bit_offset++;</span><br><span> remaining_bits_len--;</span><br><span> </span><br><span> /* extract and store no_of_bits long element from bitstream */</span><br><span> bitvec_write_field(vector, writeIndex, *pui8, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)*pui8);</span><br><span> pui8++;</span><br><span> ElementCount--;</span><br><span> </span><br><span>@@ -2522,7 +2522,7 @@</span><br><span> }</span><br><span> </span><br><span> bitvec_write_field(vector, writeIndex, !Tag, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)(!Tag));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)(!Tag));</span><br><span> bit_offset++;</span><br><span> remaining_bits_len--;</span><br><span> </span><br><span>@@ -2544,7 +2544,7 @@</span><br><span> while (ElementCount > 0)</span><br><span> { /* tag control shows existence of next list elements */</span><br><span> bitvec_write_field(vector, writeIndex, Tag, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)Tag);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)Tag);</span><br><span> bit_offset++;</span><br><span> </span><br><span> remaining_bits_len--;</span><br><span>@@ -2575,7 +2575,7 @@</span><br><span> }</span><br><span> </span><br><span> bitvec_write_field(vector, writeIndex, !Tag, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)(!Tag));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)(!Tag));</span><br><span> bit_offset++;</span><br><span> </span><br><span> pDescr++;</span><br><span>@@ -2613,15 +2613,15 @@</span><br><span> if (ElementCount != ElementNum)</span><br><span> {</span><br><span> bitvec_write_field(vector, writeIndex, Tag, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)Tag);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)Tag);</span><br><span> bit_offset++;</span><br><span> remaining_bits_len--;</span><br><span> }</span><br><span> ElementCount--;</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s { | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s { | ", pDescr->sz);</span><br><span> csnStreamInit(&arT, bit_offset, remaining_bits_len);</span><br><span> Status = csnStreamEncoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, writeIndex, pui8);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s } | ", pDescr->sz);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s } | ", pDescr->sz);</span><br><span> if (Status >= 0)</span><br><span> { /* successful completion */</span><br><span> pui8 += nSizeElement; /* -> to next */</span><br><span>@@ -2651,7 +2651,7 @@</span><br><span> { /* Verify the fixed bits */</span><br><span> guint8 no_of_bits = (guint8) pDescr->i;</span><br><span> bitvec_write_field(vector, writeIndex, pDescr->offset, no_of_bits);</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , (unsigned)pDescr->offset);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pDescr->sz , (unsigned)pDescr->offset);</span><br><span> remaining_bits_len -= no_of_bits;</span><br><span> bit_offset += no_of_bits;</span><br><span> pDescr++;</span><br><span>diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp</span><br><span>index 63498ca..bd5da4c 100644</span><br><span>--- a/tests/rlcmac/RLCMACTest.cpp</span><br><span>+++ b/tests/rlcmac/RLCMACTest.cpp</span><br><span>@@ -284,7 +284,7 @@</span><br><span> {</span><br><span> void *ctx = talloc_named_const(NULL, 1, "RLCMACTest");</span><br><span> osmo_init_logging2(ctx, &gprs_log_info);</span><br><span style="color: hsl(0, 100%, 40%);">- log_parse_category_mask(osmo_stderr_target, "DPCU,3:DLGLOBAL,1:DRLCMACDATA,2:DCSN1,2:");</span><br><span style="color: hsl(120, 100%, 40%);">+ log_parse_category_mask(osmo_stderr_target, "DPCU,3:DLGLOBAL,1:DRLCMACDATA,2:DCSN1,1:");</span><br><span> </span><br><span> log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE);</span><br><span> log_set_print_category_hex(osmo_stderr_target, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17530">change 17530</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17530"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7b42c9e21ad8d8a5b54e7a3b68490934ce3d3198 </div>
<div style="display:none"> Gerrit-Change-Number: 17530 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>