<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/17528">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">simtrace2_siff: getopt_long() returns int, not char<br><br>This may be causing unwanted behavior while parsing the command<br>line arguments, as reported by some Raspi users.<br><br>Change-Id: I5b7db0795d16ab071e255c2c689e3b4872a933bb<br>Related: OS#4223<br>---<br>M host/src/simtrace2-sniff.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c</span><br><span>index dfb6e7c..47d9e77 100644</span><br><span>--- a/host/src/simtrace2-sniff.c</span><br><span>+++ b/host/src/simtrace2-sniff.c</span><br><span>@@ -342,7 +342,7 @@</span><br><span>     while (1) {</span><br><span>          int option_index = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               char c = getopt_long(argc, argv, "hi:kV:P:C:I:S:A:", opts, &option_index);</span><br><span style="color: hsl(120, 100%, 40%);">+              int c = getopt_long(argc, argv, "hi:kV:P:C:I:S:A:", opts, &option_index);</span><br><span>              if (c == -1)</span><br><span>                         break;</span><br><span>               switch (c) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/17528">change 17528</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/17528"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5b7db0795d16ab071e255c2c689e3b4872a933bb </div>
<div style="display:none"> Gerrit-Change-Number: 17528 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>