<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17524">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use downlink BSSGP RA Cap IE<br><br>This commit is basically a revert of<br>f4bb42459ca4f3e18f9ee3d3a27389b85c7692e8, which disabled the code. That<br>commit claimed the SGSN may have providen inacurate or wrong data at the<br>time, but then it should be fixed in the SGSN.<br><br>Related: OS#1525, OS#3499<br>Change-Id: Ie36ae23203110018d4b5ae47591e0a64989e23a0<br>---<br>M src/gprs_bssgp_pcu.cpp<br>1 file changed, 1 insertion(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp</span><br><span>index 63c0a6e..0be3b3d 100644</span><br><span>--- a/src/gprs_bssgp_pcu.cpp</span><br><span>+++ b/src/gprs_bssgp_pcu.cpp</span><br><span>@@ -26,6 +26,7 @@</span><br><span> #include <tbf.h></span><br><span> #include <gprs_coding_scheme.h></span><br><span> #include <pdch.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <decoding.h></span><br><span> </span><br><span> extern "C" {</span><br><span>         #include <osmocom/gsm/protocol/gsm_23_003.h></span><br><span>@@ -52,7 +53,6 @@</span><br><span> static void bvc_timeout(void *_priv);</span><br><span> static int gprs_ns_reconnect(struct gprs_nsvc *nsvc);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span> static int parse_ra_cap(struct tlv_parsed *tp, MS_Radio_Access_capability_t *rac)</span><br><span> {</span><br><span>  bitvec *block;</span><br><span>@@ -78,7 +78,6 @@</span><br><span>   bitvec_free(block);</span><br><span>  return 0;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span> static int gprs_bssgp_pcu_rx_dl_ud(struct msgb *msg, struct tlv_parsed *tp)</span><br><span> {</span><br><span>@@ -92,9 +91,7 @@</span><br><span>     uint8_t ms_class = 0;</span><br><span>        uint8_t egprs_ms_class = 0;</span><br><span>  int rc;</span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span>         MS_Radio_Access_capability_t rac;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span>  budh = (struct bssgp_ud_hdr *)msgb_bssgph(msg);</span><br><span>      tlli = ntohl(budh->tlli);</span><br><span>@@ -128,7 +125,6 @@</span><br><span>           }</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if 0 /* Do not rely on this IE. TODO: make this configurable */</span><br><span>        /* parse ms radio access capability */</span><br><span>       if (parse_ra_cap(tp, &rac) >= 0) {</span><br><span>            /* Get the EGPRS class from the RA capability */</span><br><span>@@ -138,7 +134,6 @@</span><br><span>               LOGP(DBSSGP, LOGL_DEBUG, "Got downlink MS class %d/%d\n",</span><br><span>                  ms_class, egprs_ms_class);</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span>  /* get lifetime */</span><br><span>   uint16_t delay_csec = 0xffff;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17524">change 17524</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17524"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie36ae23203110018d4b5ae47591e0a64989e23a0 </div>
<div style="display:none"> Gerrit-Change-Number: 17524 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>