<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17439">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">srsue: Use logfile instead of stdout<br><br>newer srsLTE has fixes to exit properly after 3 seconds and then flush the log file.<br><br>Change-Id: I9801ce932ad08b7fbb6d14a66e1dba64d4af38f7<br>---<br>M src/osmo_gsm_tester/srs_ue.py<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_gsm_tester/srs_ue.py b/src/osmo_gsm_tester/srs_ue.py</span><br><span>index 20a5001..9743848 100644</span><br><span>--- a/src/osmo_gsm_tester/srs_ue.py</span><br><span>+++ b/src/osmo_gsm_tester/srs_ue.py</span><br><span>@@ -83,6 +83,12 @@</span><br><span> return</span><br><span> if self.setup_runs_locally():</span><br><span> return</span><br><span style="color: hsl(120, 100%, 40%);">+ # When using zmq, srsUE is known to hang for a few seconds before</span><br><span style="color: hsl(120, 100%, 40%);">+ # exiting (3 seconds after alarm() watchdog kicks in). We hence need to</span><br><span style="color: hsl(120, 100%, 40%);">+ # wait to make sure the remote process terminated and the file was</span><br><span style="color: hsl(120, 100%, 40%);">+ # flushed, since cleanup() triggered means only the local ssh client was killed.</span><br><span style="color: hsl(120, 100%, 40%);">+ if self._conf and self._conf.get('rf_dev_type', '') == 'zmq':</span><br><span style="color: hsl(120, 100%, 40%);">+ MainLoop.sleep(self, 3)</span><br><span> # copy back files (may not exist, for instance if there was an early error of process):</span><br><span> try:</span><br><span> self.rem_host.scpfrom('scp-back-log', self.remote_log_file, self.log_file)</span><br><span>@@ -154,7 +160,7 @@</span><br><span> args = (remote_binary, self.remote_config_file,</span><br><span> '--phy.nof_phy_threads=1',</span><br><span> '--gw.netns=' + self.netns(),</span><br><span style="color: hsl(0, 100%, 40%);">- '--log.filename=' + 'stdout', #self.remote_log_file,</span><br><span style="color: hsl(120, 100%, 40%);">+ '--log.filename=' + self.remote_log_file,</span><br><span> '--pcap.filename=' + self.remote_pcap_file,</span><br><span> '--general.metrics_csv_filename=' + self.remote_metrics_file)</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17439">change 17439</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17439"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9801ce932ad08b7fbb6d14a66e1dba64d4af38f7 </div>
<div style="display:none"> Gerrit-Change-Number: 17439 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>