<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/mncc-python/+/17409">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved; Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mncc_mt_loadgen: Don't call GsmCallFsm() with rtp_bridge=True<br><br>rtp_bridge=True triggers the automatic transmission of a MNCC_RTP_CREATE<br>when that call goes into ACTIVE state. We don't want this in the<br>case of mncc_mt_loadgen, as we perform this at a much sooner point in<br>time.<br><br>Change-Id: I8816ccb8c7dce2958496c81a95f1a91bc33e772b<br>---<br>M gsm_call_fsm.py<br>M mncc_mt_loadgen.py<br>2 files changed, 1 insertion(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gsm_call_fsm.py b/gsm_call_fsm.py</span><br><span>index c8bcf39..5f846e1 100644</span><br><span>--- a/gsm_call_fsm.py</span><br><span>+++ b/gsm_call_fsm.py</span><br><span>@@ -228,8 +228,6 @@</span><br><span> </span><br><span> # RTP</span><br><span> def _do_mncc_rtp_create_ind(self, mncc_msg):</span><br><span style="color: hsl(0, 100%, 40%);">- if self.rtp_bridge == False:</span><br><span style="color: hsl(0, 100%, 40%);">- raise Exception('GsmCallFsm', 'rtp_create_ind but not in RTP bridge mode')</span><br><span> self.rtp = mncc_msg</span><br><span> # notify the call controller about this</span><br><span> self.ctrl_ref.tell({'type':'rtp_create_ind', 'called':self.called, 'rtp':self.rtp})</span><br><span>@@ -336,8 +334,6 @@</span><br><span> </span><br><span> def rtp_created(self, msisdn, rtp):</span><br><span> log.info('CallConnector:rtp_created(%s) %s' % (msisdn, rtp))</span><br><span style="color: hsl(0, 100%, 40%);">- if self.rtp_bridge == False:</span><br><span style="color: hsl(0, 100%, 40%);">- raise Exception('GsmCallConnector', 'rtp_created but not in RTP bridge mode')</span><br><span> if msisdn == self.msisdn_a: # A->B leg</span><br><span> self.rtp_a = rtp</span><br><span> elif msisdn == self.msisdn_b: # B->A leg</span><br><span>diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py</span><br><span>index a4c0c85..021d619 100755</span><br><span>--- a/mncc_mt_loadgen.py</span><br><span>+++ b/mncc_mt_loadgen.py</span><br><span>@@ -103,7 +103,7 @@</span><br><span> self.mncc_act = mncc_act</span><br><span> self.ctrl_act = ctrl_act</span><br><span> self.codecs_permitted = codecs_permitted</span><br><span style="color: hsl(0, 100%, 40%);">- self.call = GsmCallFsm.start(self.mncc_act, self.actor_ref, True, self.codecs_permitted)</span><br><span style="color: hsl(120, 100%, 40%);">+ self.call = GsmCallFsm.start(self.mncc_act, self.actor_ref, False, self.codecs_permitted)</span><br><span> self.callref = self.call.ask({'type':'get_callref'})</span><br><span> self.state = 'NULL'</span><br><span> self.rtp_msc = None</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/mncc-python/+/17409">change 17409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/mncc-python/+/17409"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: mncc-python </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8816ccb8c7dce2958496c81a95f1a91bc33e772b </div>
<div style="display:none"> Gerrit-Change-Number: 17409 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>