<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17411">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: Use INIT_LLIST_HEAD() and llist_add_tail()<br><br>... instead of manually re-inventing them.<br><br>Change-Id: I7e0810aa7fd1daa8f9f3e46a207589a4c6da836b<br>---<br>M src/host/virt_phy/src/virt_l1_sched_simple.c<br>1 file changed, 2 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/virt_phy/src/virt_l1_sched_simple.c b/src/host/virt_phy/src/virt_l1_sched_simple.c</span><br><span>index 4737135..a14a115 100644</span><br><span>--- a/src/host/virt_phy/src/virt_l1_sched_simple.c</span><br><span>+++ b/src/host/virt_phy/src/virt_l1_sched_simple.c</span><br><span>@@ -129,12 +129,8 @@</span><br><span>                /* list did not contain mframe item with needed fn */</span><br><span>                mi_fn = talloc_zero(ms, struct virt_l1_sched_mframe_item);</span><br><span>           mi_fn->fn = fn;</span><br><span style="color: hsl(0, 100%, 40%);">-              /* need to manually init the struct content.... no so happy */</span><br><span style="color: hsl(0, 100%, 40%);">-          mi_fn->tdma_item_list.prev = &mi_fn->tdma_item_list;</span><br><span style="color: hsl(0, 100%, 40%);">-          mi_fn->tdma_item_list.next = &mi_fn->tdma_item_list;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-          /* TODO: check if we get an error if list is empty... */</span><br><span style="color: hsl(0, 100%, 40%);">-                llist_add(&mi_fn->mframe_item_entry, mi_next->mframe_item_entry.prev);</span><br><span style="color: hsl(120, 100%, 40%);">+              INIT_LLIST_HEAD(&mi_fn->tdma_item_list);</span><br><span style="color: hsl(120, 100%, 40%);">+               llist_add_tail(&mi_fn->mframe_item_entry, &mi_next->mframe_item_entry);</span><br><span>        }</span><br><span> </span><br><span>        ti_new = talloc_zero(mi_fn, struct virt_l1_sched_tdma_item);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17411">change 17411</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/17411"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e0810aa7fd1daa8f9f3e46a207589a4c6da836b </div>
<div style="display:none"> Gerrit-Change-Number: 17411 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>