<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn">File bts/BTS_Tests_perf.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@53">Patch Set #1, Line 53:</a> <code style="font-family:monospace,monospace">function f_uin32t2ip(uint32_t uint32t) return charstring</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">These functions look like good candidates to be introduced in a more generic already existing files, such as Misc_helpers.ttcn or similar.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@60">Patch Set #1, Line 60:</a> <code style="font-family:monospace,monospace"> octet_1 := uint32t / 16777216;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Having a param called uint32t is at least very confusing.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace"> addr := octet_1 * 16777216 + octet_2 * 65536 + octet_3 * 255 + octet_4;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">all the octet_* stuff can be dropped, simply use segAddr[0], etc. directly here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@113">Patch Set #1, Line 113:</a> <code style="font-family:monospace,monospace"> var integer channels := sizeof(chan_nr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">channels suggest it's an array of channels. What about num_channels? or num_chans.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@124">Patch Set #1, Line 124:</a> <code style="font-family:monospace,monospace"> ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM1 /* AMR*/)),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So I did look at the wrong place when I did this?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@138">Patch Set #1, Line 138:</a> <code style="font-family:monospace,monospace"> /* Netotiate RTP TX (BTS) port for activated channel */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">typo: Negotiate<br>Tx</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@148">Patch Set #1, Line 148:</a> <code style="font-family:monospace,monospace"> f_rtpem_configure(RTPEM[0], rtp_cfg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">should be RTPEM[i] right?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/BTS_Tests_perf.ttcn@165">Patch Set #1, Line 165:</a> <code style="font-family:monospace,monospace"> f_sleep(1.0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we split the loop into two parts (two loops) so we only f_sleep(1.0) here?<br>I mean:<br>foreach(chan) f_rtpem_mode()<br>f_sleep(1)<br>foreach(chan) f_rsl_transceive()</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/RTP_CodecPort_CtrlFunct.ttcn">File bts/RTP_CodecPort_CtrlFunct.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285/1/bts/RTP_CodecPort_CtrlFunct.ttcn@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">module RTP_CodecPort_CtrlFunct {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">just wondering: why do we need all this? Didn't we already have an RTP_CodecPort in some other place? Why not reusing it from lib/ ?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285">change 17285</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17285"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I21a610533d5be2e1647cc6a72423e056b39d1217 </div>
<div style="display:none"> Gerrit-Change-Number: 17285 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 27 Feb 2020 10:38:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>