<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17269">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-sim-test: initalize tlv_parsed structure with zeros<br><br>The variable struct tlv_parsed tp in dump_file() is not pre-initalized.<br>Lets make sure that it is pre-initalized to avoid accessing uninitalized<br>memory in error/corner cases.<br><br>Change-Id: I6b0209b966127a4195e6f4bcb43d49387c7646ce<br>Fixes: CID#208435<br>---<br>M utils/osmo-sim-test.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/17269/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c</span><br><span>index d33f1ba..52f146d 100644</span><br><span>--- a/utils/osmo-sim-test.c</span><br><span>+++ b/utils/osmo-sim-test.c</span><br><span>@@ -319,7 +319,7 @@</span><br><span> </span><br><span> static int dump_file(struct osim_chan_hdl *chan, uint16_t fid)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  struct tlv_parsed tp;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct tlv_parsed tp = { 0 };</span><br><span>        struct osim_fcp_fd_decoded ffdd;</span><br><span>     struct msgb *msg, *rmsg;</span><br><span>     int rc, i, offset;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/17269">change 17269</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/17269"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6b0209b966127a4195e6f4bcb43d49387c7646ce </div>
<div style="display:none"> Gerrit-Change-Number: 17269 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>