<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/17201">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ansible: gsm-tester: Use file module instead of manual mkdir<br><br>From ansible: [WARNING]: Consider using the file module with state=directory rather than running 'mkdir'.<br><br>Change-Id: I2c541878033360a9d427d13b62c1cc075d5f92b7<br>---<br>M ansible/roles/gsm-tester/tasks/main.yml<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ansible/roles/gsm-tester/tasks/main.yml b/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>index ecdd254..db2a16c 100644</span><br><span>--- a/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>+++ b/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>@@ -365,18 +365,22 @@</span><br><span>   tags:</span><br><span>     - osmo-gsm-tester-proc</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+- name: Install osmo-gsm-tester script helpers to /usr/local/bin (PATH) (mkdir)</span><br><span style="color: hsl(120, 100%, 40%);">+  file: path=/usr/local/bin state=directory</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> - name: Install osmo-gsm-tester script helpers to /usr/local/bin (PATH)</span><br><span>   shell: |</span><br><span style="color: hsl(0, 100%, 40%);">-      mkdir -p /usr/local/bin/ && \</span><br><span>       cp utils/bin/*.sh /usr/local/bin/</span><br><span>   args:</span><br><span>     chdir: /root/osmo-gsm-tester</span><br><span>   tags:</span><br><span>     - osmo-gsm-tester-proc</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+- name: Install osmo-gsm-tester sudoers.d files to /etc/sudoers.d/ (PATH (mkdir)</span><br><span style="color: hsl(120, 100%, 40%);">+  file: path=/etc/sudoers.d/ state=directory</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> - name: Install osmo-gsm-tester sudoers.d files to /etc/sudoers.d/ (PATH)</span><br><span>   shell: |</span><br><span style="color: hsl(0, 100%, 40%);">-      mkdir -p /etc/sudoers.d/ && \</span><br><span>       cp utils/sudoers.d/* /etc/sudoers.d/</span><br><span>   args:</span><br><span>     chdir: /root/osmo-gsm-tester</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/17201">change 17201</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/17201"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2c541878033360a9d427d13b62c1cc075d5f92b7 </div>
<div style="display:none"> Gerrit-Change-Number: 17201 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>