<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/17241">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">server: Don't accept out-of-range bank/client/slot numbers on REST<br><br>Change-Id: Id0c9dcda58d1f85df431a74bbfba06cfaa0af69d<br>---<br>M src/server/rest_api.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/41/17241/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/server/rest_api.c b/src/server/rest_api.c</span><br><span>index abd46b9..ff1b588 100644</span><br><span>--- a/src/server/rest_api.c</span><br><span>+++ b/src/server/rest_api.c</span><br><span>@@ -86,6 +86,8 @@</span><br><span>          return -EINVAL;</span><br><span>      bslot->bank_id = json_integer_value(jbank_id);</span><br><span>    bslot->slot_nr = json_integer_value(jslot_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (bslot->bank_id > 1023 || bslot->slot_nr > 1023)</span><br><span style="color: hsl(120, 100%, 40%);">+               return -EINVAL;</span><br><span>      return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -110,6 +112,8 @@</span><br><span>             return -EINVAL;</span><br><span>      cslot->client_id = json_integer_value(jclient_id);</span><br><span>        cslot->slot_nr = json_integer_value(jslot_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (cslot->client_id > 1023 || cslot->slot_nr > 1023)</span><br><span style="color: hsl(120, 100%, 40%);">+             return -EINVAL;</span><br><span>      return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/17241">change 17241</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/17241"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id0c9dcda58d1f85df431a74bbfba06cfaa0af69d </div>
<div style="display:none"> Gerrit-Change-Number: 17241 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>