<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/17198">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ansible: gsm-tester: add some tags to tasks<br><br>Change-Id: I1fe26d519d4d63d4bef33c1db2abf98a40913f98<br>---<br>M ansible/roles/gsm-tester/tasks/main.yml<br>1 file changed, 88 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/17198/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ansible/roles/gsm-tester/tasks/main.yml b/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>index 9f3fd25..1492305 100644</span><br><span>--- a/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>+++ b/ansible/roles/gsm-tester/tasks/main.yml</span><br><span>@@ -35,6 +35,8 @@</span><br><span>     - libasound2-dev</span><br><span>     - liblua5.3-dev</span><br><span>     - lua-socket</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmocom</span><br><span> </span><br><span> # mdbus2 is not available in debian10. TODO: compile it for >9</span><br><span> - name: install mdbus2</span><br><span>@@ -43,6 +45,9 @@</span><br><span>   with_items:</span><br><span>     - mdbus2</span><br><span>   when: ansible_distribution == 'Debian' and ansible_distribution_version <= '9'</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: install srsLTE runtime dependencies</span><br><span>   apt:</span><br><span>@@ -59,21 +64,31 @@</span><br><span>     - libczmq-dev</span><br><span>     - libsoapysdr-dev</span><br><span>     - soapysdr0.7-module-lms7</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - srs</span><br><span> </span><br><span> - name: install ofono build dependencies</span><br><span>   apt:</span><br><span>     name: ofono</span><br><span>     state: build-dep</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: install libqmi-glib a dependency of sysmocom ofono</span><br><span>   apt:</span><br><span>     name: libqmi-glib-dev</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: install uhub dependencies</span><br><span>   apt:</span><br><span>     name: "{{ item }}"</span><br><span>   with_items:</span><br><span>     - libusb-1.0-0-dev</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: setup uhubctl repository</span><br><span>   git:</span><br><span>@@ -82,6 +97,8 @@</span><br><span>     version: master</span><br><span>     clone: yes</span><br><span>     update: no</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: build uhubctl</span><br><span>   shell: |</span><br><span>@@ -90,6 +107,8 @@</span><br><span>   args:</span><br><span>     chdir: /root/uhubctl</span><br><span>     creates: /usr/sbin/uhubctl</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> # TODO: move this into restart-modems.d directory</span><br><span> - name: copy quad_modem_power_cycle.sh</span><br><span>@@ -98,7 +117,7 @@</span><br><span>     dest: /usr/local/bin/quad_modem_power_cycle.sh</span><br><span>     mode: 0755</span><br><span>   tags:</span><br><span style="color: hsl(0, 100%, 40%);">-    - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: setup ofono repository</span><br><span>   git:</span><br><span>@@ -109,6 +128,7 @@</span><br><span>     update: no</span><br><span>   tags:</span><br><span>     - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: build ofono</span><br><span>   shell: |</span><br><span>@@ -122,6 +142,7 @@</span><br><span>     creates: /usr/local/sbin/ofonod</span><br><span>   tags:</span><br><span>     - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: ensure ofono is started</span><br><span>   service:</span><br><span>@@ -130,6 +151,7 @@</span><br><span>     enabled: yes</span><br><span>   tags:</span><br><span>     - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> # patchelf 0.9 available in debian has bugs with certain binaries. Version 0.10</span><br><span> # fails on other binaries, so we need both 0.9 and 0.10 versions installed.</span><br><span>@@ -142,6 +164,7 @@</span><br><span>     update: no</span><br><span>   tags:</span><br><span>     - patchelf</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: build patchelf v0.10</span><br><span>   shell: |</span><br><span>@@ -155,13 +178,12 @@</span><br><span>     creates: /opt/bin/patchelf-v0.10</span><br><span>   tags:</span><br><span>     - patchelf</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-- name: install gsm tester dependencies</span><br><span style="color: hsl(120, 100%, 40%);">+- name: install gsm tester dependencies (main)</span><br><span>   apt:</span><br><span>     name: "{{ item }}"</span><br><span>   with_items:</span><br><span style="color: hsl(0, 100%, 40%);">-    - dbus</span><br><span style="color: hsl(0, 100%, 40%);">-    - tcpdump</span><br><span>     - sqlite3</span><br><span>     - python3</span><br><span>     - python3-setuptools</span><br><span>@@ -170,11 +192,23 @@</span><br><span>     - python3-gi</span><br><span>     - ofono</span><br><span>     - patchelf</span><br><span style="color: hsl(0, 100%, 40%);">-    - sudo</span><br><span>     - libcap2-bin</span><br><span>     - python3-pip</span><br><span>     - udhcpc</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+- name: install gsm tester dependencies (proc)</span><br><span style="color: hsl(120, 100%, 40%);">+  apt:</span><br><span style="color: hsl(120, 100%, 40%);">+    name: "{{ item }}"</span><br><span style="color: hsl(120, 100%, 40%);">+  with_items:</span><br><span style="color: hsl(120, 100%, 40%);">+    - tcpdump</span><br><span style="color: hsl(120, 100%, 40%);">+    - patchelf</span><br><span style="color: hsl(120, 100%, 40%);">+    - libcap2-bin</span><br><span>     - iperf3</span><br><span style="color: hsl(120, 100%, 40%);">+    - sudo</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: install gsm tester pip dependencies</span><br><span>   pip:</span><br><span>@@ -186,11 +220,16 @@</span><br><span>     - pydbus</span><br><span>     - pyusb</span><br><span>     - pysispm</span><br><span style="color: hsl(0, 100%, 40%);">-  tags: [pip]</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - pip</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> - name: create group osmo-gsm-tester</span><br><span>   group:</span><br><span>     name: osmo-gsm-tester</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: add jenkins to osmo-gsm-tester and systemd-journal</span><br><span>   user:</span><br><span>@@ -202,6 +241,8 @@</span><br><span>     - systemd-journal</span><br><span>     - osmo-gsm-tester</span><br><span>     - dialout</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> - name: setup state directory</span><br><span>   file:</span><br><span>@@ -209,10 +250,14 @@</span><br><span>     state: directory</span><br><span>     group: osmo-gsm-tester</span><br><span>     mode: g+rwxs</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> - name: install acl</span><br><span>   apt:</span><br><span>     name: acl</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> # Ensure the group always has access to all files</span><br><span> - name: add acl to state directory</span><br><span>@@ -223,6 +268,8 @@</span><br><span>     entity: osmo-gsm-tester</span><br><span>     default: yes</span><br><span>     permissions: rwx</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> - name: create trials directory</span><br><span>   file:</span><br><span>@@ -230,39 +277,57 @@</span><br><span>     state: directory</span><br><span>     group: osmo-gsm-tester</span><br><span>     mode: g+rwxs</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> - name: allow osmo-gsm-tester to access ofono</span><br><span>   copy:</span><br><span>     src: dbus_osmo-gsm-tester.conf</span><br><span>     dest: /etc/dbus-1/system.d/osmo-gsm-tester.conf</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - ofono</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: ensure tcpdump can be called by osmo-gsm-tester</span><br><span>   file:</span><br><span>     path: /usr/sbin/tcpdump</span><br><span>     group: osmo-gsm-tester</span><br><span>     mode: 0750</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span style="color: hsl(120, 100%, 40%);">+    - tcpdump</span><br><span> </span><br><span> - name: create a symlink for tcpdump</span><br><span>   file:</span><br><span>     src: /usr/sbin/tcpdump</span><br><span>     dest: /usr/local/bin/tcpdump</span><br><span>     state: link</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span style="color: hsl(120, 100%, 40%);">+    - tcpdump</span><br><span> </span><br><span> - name: add correct capabilities to tcpdump</span><br><span>   capabilities:</span><br><span>     path: /usr/sbin/tcpdump</span><br><span>     capability: cap_net_raw,cap_net_admin=eip</span><br><span>     state: present</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span style="color: hsl(120, 100%, 40%);">+    - tcpdump</span><br><span> </span><br><span> - name: allow core files for the group osmo-gsm-tester</span><br><span>   copy:</span><br><span>     content: "@osmo-gsm-tester - core unlimited"</span><br><span>     dest: /etc/security/limits.d/osmo-gsm-tester_allowcore.conf</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: allow rt priority for the group osmo-gsm-tester</span><br><span>   copy:</span><br><span>     content: "@osmo-gsm-tester - rtprio 99"</span><br><span>     dest: /etc/security/limits.d/osmo-gsm-tester_rtprio.conf</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: setup osmo-gsm-tester repository</span><br><span>   git:</span><br><span>@@ -272,7 +337,7 @@</span><br><span>     clone: yes</span><br><span>     update: no</span><br><span>   tags:</span><br><span style="color: hsl(0, 100%, 40%);">-    - osmo-gsm-tester</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: Install osmo-gsm-tester script helpers to /usr/local/bin (PATH)</span><br><span>   shell: |</span><br><span>@@ -281,7 +346,7 @@</span><br><span>   args:</span><br><span>     chdir: /root/osmo-gsm-tester</span><br><span>   tags:</span><br><span style="color: hsl(0, 100%, 40%);">-    - osmo-gsm-tester</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: Install osmo-gsm-tester sudoers.d files to /etc/sudoers.d/ (PATH)</span><br><span>   shell: |</span><br><span>@@ -290,37 +355,51 @@</span><br><span>   args:</span><br><span>     chdir: /root/osmo-gsm-tester</span><br><span>   tags:</span><br><span style="color: hsl(0, 100%, 40%);">-    - osmo-gsm-tester</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-proc</span><br><span> </span><br><span> - name: logrotate limit filesizes to 10M</span><br><span>   copy:</span><br><span>     content: "maxsize 10M"</span><br><span>     dest: /etc/logrotate.d/maxsize</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span> </span><br><span> - name: install sispmctl (usb power socket)</span><br><span>   apt:</span><br><span>     name: sispmctl</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - sispm</span><br><span> </span><br><span> - name: allow group osmo-gsm-tester to access sispm devices</span><br><span>   copy:</span><br><span>     src: 60-sispmctl.rules</span><br><span>     dest: /etc/udev/rules.d/</span><br><span>   notify: restart udev</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - sispm</span><br><span> </span><br><span> - name: allow group osmo-gsm-tester to access LMS devices</span><br><span>   copy:</span><br><span>     src: 64-limesuite.rules</span><br><span>     dest: /etc/udev/rules.d/</span><br><span>   notify: restart udev</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - lms</span><br><span> </span><br><span> - name: use persistent naming for modem network interfaces</span><br><span>   copy:</span><br><span>     src: 70-net-setup-link-modems.rules</span><br><span>     dest: /etc/udev/rules.d/</span><br><span>   notify: restart udev</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - modem</span><br><span> </span><br><span> - name: avoid dhcpcd managing modem interfaces and racing with udev rename</span><br><span>   lineinfile:</span><br><span>     path: /etc/dhcpcd.conf</span><br><span>     regexp: '^denyinterfaces'</span><br><span>     line: 'denyinterfaces ww* r*'</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+  tags:</span><br><span style="color: hsl(120, 100%, 40%);">+    - osmo-gsm-tester-main</span><br><span style="color: hsl(120, 100%, 40%);">+    - dhcpcd</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/17198">change 17198</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/17198"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1fe26d519d4d63d4bef33c1db2abf98a40913f98 </div>
<div style="display:none"> Gerrit-Change-Number: 17198 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>