<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17194">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1: fix csnStreamDecoder(): do not subtract no_of_bits twice<br><br>Found while doing differential analysis (comparison against the<br>original implementation from Wireshark).<br><br>Change-Id: Id2a4f03035cd8354d3fba0ad37571453d3986d21<br>---<br>M src/csn1.c<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/17194/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.c b/src/csn1.c</span><br><span>index eedad75..a766bd3 100644</span><br><span>--- a/src/csn1.c</span><br><span>+++ b/src/csn1.c</span><br><span>@@ -306,7 +306,6 @@</span><br><span> </span><br><span>         if (remaining_bits_len >= no_of_bits)</span><br><span>         {</span><br><span style="color: hsl(0, 100%, 40%);">-          remaining_bits_len -= no_of_bits;</span><br><span>           if (no_of_bits <= 8)</span><br><span>           {</span><br><span>         guint8 ui8 = get_masked_bits8(vector, readIndex, bit_offset, no_of_bits);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17194">change 17194</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17194"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id2a4f03035cd8354d3fba0ad37571453d3986d21 </div>
<div style="display:none"> Gerrit-Change-Number: 17194 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>