<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17195">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1: fix csnStreamDecoder(): always keep remaining_bits_len updated<br><br>Found while doing differential analysis (comparison against the<br>original implementation from Wireshark).<br><br>Change-Id: I9f7fa9c3f2f4ff5213dded930cee7ec509b9d799<br>---<br>M src/csn1.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.c b/src/csn1.c</span><br><span>index a766bd3..31b8e00 100644</span><br><span>--- a/src/csn1.c</span><br><span>+++ b/src/csn1.c</span><br><span>@@ -656,8 +656,6 @@</span><br><span>             guint8 no_of_bits = (guint8) pDescr->i;</span><br><span>             if (remaining_bits_len >= no_of_bits)</span><br><span>             {</span><br><span style="color: hsl(0, 100%, 40%);">-              remaining_bits_len -= no_of_bits;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>               if (no_of_bits <= 8)</span><br><span>               {</span><br><span>              guint8 ui8 = bitvec_read_field(vector, readIndex,  no_of_bits);</span><br><span>@@ -689,6 +687,7 @@</span><br><span>               return ProcessError(readIndex,"csnStreamDecoder", CSN_ERROR_GENERAL, pDescr);</span><br><span>             }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+            remaining_bits_len -= no_of_bits;</span><br><span>             bit_offset += no_of_bits;</span><br><span>             pDescr++;</span><br><span>             break;</span><br><span>@@ -731,6 +730,7 @@</span><br><span>               return ProcessError(readIndex,"csnStreamDecoder", CSN_ERROR_NEED_MORE_BITS_TO_UNPACK, pDescr);</span><br><span>             }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+            remaining_bits_len -= no_of_bits;</span><br><span>             bit_offset += no_of_bits;</span><br><span>             pDescr++;</span><br><span>             break;</span><br><span>@@ -759,6 +759,7 @@</span><br><span>               return ProcessError(readIndex,"csnStreamDecoder", CSN_ERROR_NEED_MORE_BITS_TO_UNPACK, pDescr);</span><br><span>             }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+            remaining_bits_len -= no_of_bits;</span><br><span>             bit_offset += no_of_bits;</span><br><span>             pDescr++;</span><br><span>             break;</span><br><span>@@ -1310,6 +1311,7 @@</span><br><span>         LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , bitvec_get_uint(vector, 1));</span><br><span> </span><br><span>         /* existNextElement() returned FALSE, 1 bit consumed */</span><br><span style="color: hsl(120, 100%, 40%);">+        remaining_bits_len--;</span><br><span>         bit_offset++;</span><br><span> </span><br><span>         /* Store the counted number of elements of the array */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17195">change 17195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9f7fa9c3f2f4ff5213dded930cee7ec509b9d799 </div>
<div style="display:none"> Gerrit-Change-Number: 17195 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>