<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17191">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1: fix existNextElement(): use bitvec_get_bit_pos()<br><br>As was discovered recently (see OS#4388), bitvec_read_field()<br>would never return a negative value because its return type<br>is unsigned (uint64_t).<br><br>We don't really need to get more than one bit, so let's just<br>use the bitvec_get_bit_pos() instead.<br><br>Change-Id: I763a295cd955cd33f542292c85d97ff82f6b49bc<br>Related: OS#4388<br>---<br>M src/csn1.cpp<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/91/17191/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.cpp b/src/csn1.cpp</span><br><span>index 5928d69..7be28a1 100644</span><br><span>--- a/src/csn1.cpp</span><br><span>+++ b/src/csn1.cpp</span><br><span>@@ -137,7 +137,7 @@</span><br><span> static gboolean</span><br><span> existNextElement(bitvec *vector, unsigned& readIndex, guint8 Tag)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  guint8 res = bitvec_read_field(vector, &readIndex, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+  int res = bitvec_get_bit_pos(vector, readIndex++);</span><br><span>   if (Tag == STANDARD_TAG)</span><br><span>   {</span><br><span>     return (res > 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17191">change 17191</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17191"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I763a295cd955cd33f542292c85d97ff82f6b49bc </div>
<div style="display:none"> Gerrit-Change-Number: 17191 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>