<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/16981">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pySim-read.py: print meaningful message when SPN is not set<br><br>Change-Id: I1d98520f33a8564c7d69f50a0811204f138f9dca<br>---<br>M pySim-read.py<br>M pysim-testdata/sysmoISIM-SJA2.ok<br>M pysim-testdata/sysmosim-gr1.ok<br>3 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index 853e924..d753c8b 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -126,7 +126,9 @@</span><br><span>            (res, sw) = scc.read_binary(EF['SPN'])</span><br><span>               if sw == '9000':</span><br><span>                     spn_res = dec_spn(res)</span><br><span style="color: hsl(0, 100%, 40%);">-                  print("SPN: %s\nDisplay HPLMN: %s\nDisplay OPLMN: %s" % (spn_res[0], spn_res[1], spn_res[2],))</span><br><span style="color: hsl(120, 100%, 40%);">+                      print("SPN: %s" % (spn_res[0] or "Not available"))</span><br><span style="color: hsl(120, 100%, 40%);">+                        print("Display HPLMN: %s" % (spn_res[1],))</span><br><span style="color: hsl(120, 100%, 40%);">+                  print("Display OPLMN: %s" % (spn_res[2],))</span><br><span>                 else:</span><br><span>                        print("SPN: Can't read, response code = %s" % (sw,))</span><br><span>   except Exception as e:</span><br><span>diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>index 7346134..77c4878 100644</span><br><span>--- a/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>+++ b/pysim-testdata/sysmoISIM-SJA2.ok</span><br><span>@@ -3,7 +3,7 @@</span><br><span> ICCID: 8988211900000000004</span><br><span> IMSI: 001010000000102</span><br><span> SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000</span><br><span style="color: hsl(0, 100%, 40%);">-SPN: </span><br><span style="color: hsl(120, 100%, 40%);">+SPN: Not available</span><br><span> Display HPLMN: False</span><br><span> Display OPLMN: False</span><br><span> PLMNsel: fff11fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span>diff --git a/pysim-testdata/sysmosim-gr1.ok b/pysim-testdata/sysmosim-gr1.ok</span><br><span>index b306f4d..f7df5cf 100644</span><br><span>--- a/pysim-testdata/sysmosim-gr1.ok</span><br><span>+++ b/pysim-testdata/sysmosim-gr1.ok</span><br><span>@@ -3,7 +3,7 @@</span><br><span> ICCID: 1122334455667788990</span><br><span> IMSI: 001010000000102</span><br><span> SMSP: ffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000</span><br><span style="color: hsl(0, 100%, 40%);">-SPN: </span><br><span style="color: hsl(120, 100%, 40%);">+SPN: Not available</span><br><span> Display HPLMN: False</span><br><span> Display OPLMN: False</span><br><span> PLMNsel: fff11fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/16981">change 16981</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/16981"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1d98520f33a8564c7d69f50a0811204f138f9dca </div>
<div style="display:none"> Gerrit-Change-Number: 16981 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>