<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17105">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf: fix NULL pointer dereference in create_[ul|dl]_ass()<br><br>The problem is that bitvec_free() is not NULL-safe. Ideally we<br>need to fix it in libosmocore [1], but let's also fix it here,<br>so OsmoPCU can be safely used with older libosmocore versions.<br><br>[1] https://gerrit.osmocom.org/c/libosmocore/+/17114<br><br>Change-Id: I7647d17b3d03f8e193ef6e793a2d3c1967744eef<br>Fixes: CID#208181, CID#208179<br>---<br>M src/tbf.cpp<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf.cpp b/src/tbf.cpp</span><br><span>index 2f79a98..5e222ae 100644</span><br><span>--- a/src/tbf.cpp</span><br><span>+++ b/src/tbf.cpp</span><br><span>@@ -1303,7 +1303,8 @@</span><br><span>        return msg;</span><br><span> </span><br><span> free_ret:</span><br><span style="color: hsl(0, 100%, 40%);">-    bitvec_free(ass_vec);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ass_vec != NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+          bitvec_free(ass_vec);</span><br><span>        talloc_free(mac_control_block);</span><br><span>      msgb_free(msg);</span><br><span>      return NULL;</span><br><span>@@ -1398,7 +1399,8 @@</span><br><span>         return msg;</span><br><span> </span><br><span> free_ret:</span><br><span style="color: hsl(0, 100%, 40%);">-    bitvec_free(ass_vec);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ass_vec != NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+          bitvec_free(ass_vec);</span><br><span>        talloc_free(mac_control_block);</span><br><span>      msgb_free(msg);</span><br><span>      return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17105">change 17105</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17105"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7647d17b3d03f8e193ef6e793a2d3c1967744eef </div>
<div style="display:none"> Gerrit-Change-Number: 17105 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>