<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17108">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">conv: prevent theoretical NULL pointer dereference in osmo_conv_encode()<br><br>A caller shall never pass NULL to osmo_conv_encode().<br><br>Change-Id: Ice0050cd7c7e3fcbf57c2c73682ca28843a92d8b<br>Fixes: CID#208174<br>---<br>M src/conv.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/conv.c b/src/conv.c</span><br><span>index a2c13de..06c4299 100644</span><br><span>--- a/src/conv.c</span><br><span>+++ b/src/conv.c</span><br><span>@@ -36,6 +36,7 @@</span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/utils.h></span><br><span> #include <osmocom/core/bits.h></span><br><span> #include <osmocom/core/conv.h></span><br><span> </span><br><span>@@ -87,6 +88,7 @@</span><br><span>                       const struct osmo_conv_code *code)</span><br><span> {</span><br><span>     memset(encoder, 0x00, sizeof(struct osmo_conv_encoder));</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(code != NULL);</span><br><span>   encoder->code = code;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/17108">change 17108</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/17108"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice0050cd7c7e3fcbf57c2c73682ca28843a92d8b </div>
<div style="display:none"> Gerrit-Change-Number: 17108 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>