<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16347">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node()<br><br>Since I2b32b4fe20732728db6e9cdac7e484d96ab86dc5, go_parent_cb()<br>is completely optional. It no longer has the task to determine<br>the correct parent node. The is_config_node() callback is no<br>longer needed too. Get rid of them.<br><br>Since Ic5e69a396df659933fd4d50298b9925e837a6861 we depend on 1.3.0.<br><br>Change-Id: Id7ce8c4e1ac43747ad40a06d01433c366da07b42<br>---<br>M src/pcu_vty.c<br>1 file changed, 0 insertions(+), 31 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_vty.c b/src/pcu_vty.c</span><br><span>index 26d0b18..94215d7 100644</span><br><span>--- a/src/pcu_vty.c</span><br><span>+++ b/src/pcu_vty.c</span><br><span>@@ -91,35 +91,6 @@</span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-int pcu_vty_go_parent(struct vty *vty)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-     switch (vty->node) {</span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span style="color: hsl(0, 100%, 40%);">-    case TRX_NODE:</span><br><span style="color: hsl(0, 100%, 40%);">-          vty->node = PCU_NODE;</span><br><span style="color: hsl(0, 100%, 40%);">-                {</span><br><span style="color: hsl(0, 100%, 40%);">-                       struct gsm_bts_trx *trx = vty->index;</span><br><span style="color: hsl(0, 100%, 40%);">-                        vty->index = trx->bts;</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(0, 100%, 40%);">-               break;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-    default:</span><br><span style="color: hsl(0, 100%, 40%);">-                vty->node = CONFIG_NODE;</span><br><span style="color: hsl(0, 100%, 40%);">-     }</span><br><span style="color: hsl(0, 100%, 40%);">-       return (enum node_type) vty->node;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-int pcu_vty_is_config_node(struct vty *vty, int node)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-    switch (node) {</span><br><span style="color: hsl(0, 100%, 40%);">- case PCU_NODE:</span><br><span style="color: hsl(0, 100%, 40%);">-          return 1;</span><br><span style="color: hsl(0, 100%, 40%);">-       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static struct cmd_node pcu_node = {</span><br><span>    (enum node_type) PCU_NODE,</span><br><span>   "%s(config-pcu)# ",</span><br><span>@@ -1218,8 +1189,6 @@</span><br><span>        .name           = "OsmoPCU",</span><br><span>       .version        = PACKAGE_VERSION,</span><br><span>   .copyright      = pcu_copyright,</span><br><span style="color: hsl(0, 100%, 40%);">-        .go_parent_cb   = pcu_vty_go_parent,</span><br><span style="color: hsl(0, 100%, 40%);">-    .is_config_node = pcu_vty_is_config_node,</span><br><span> };</span><br><span> </span><br><span> int pcu_vty_init(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16347">change 16347</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16347"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id7ce8c4e1ac43747ad40a06d01433c366da07b42 </div>
<div style="display:none"> Gerrit-Change-Number: 16347 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>